Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2760643003: Reenable WebView KeySystem tests (Closed)

Created:
3 years, 9 months ago by jrummell
Modified:
3 years, 9 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable WebView KeySystem tests Tests were failing due to copies of //media/base/android code included in multiple libraries. BUG=701916 TEST=tests pass with component builds on both K and M devices Review-Url: https://codereview.chromium.org/2760643003 Cr-Commit-Position: refs/heads/master@{#458155} Committed: https://chromium.googlesource.com/chromium/src/+/09702159bbbe183dee5baa93f14b2b0c53ac9efe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jrummell
PTAL. Simple re-enable of the tests. Will only be landed once https://codereview.chromium.org/2757463004/ has landed.
3 years, 9 months ago (2017-03-17 23:30:54 UTC) #2
xhwang
Thanks for the fix!!! LGTM
3 years, 9 months ago (2017-03-17 23:35:35 UTC) #3
sgurun-gerrit only
On 2017/03/17 23:35:35, xhwang_slow wrote: > Thanks for the fix!!! > > LGTM LGTM
3 years, 9 months ago (2017-03-20 19:26:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760643003/1
3 years, 9 months ago (2017-03-20 19:29:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/09702159bbbe183dee5baa93f14b2b0c53ac9efe
3 years, 9 months ago (2017-03-20 20:05:45 UTC) #9
jam1
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2761133002/ by jam@google.com. ...
3 years, 9 months ago (2017-03-21 00:13:39 UTC) #10
jam
3 years, 9 months ago (2017-03-21 00:15:34 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2766483002/ by jam@chromium.org.

The reason for reverting is: This is still failing, see

https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit....

Powered by Google App Engine
This is Rietveld 408576698