Move more from WmShell to Shell

Move more from WmShell to Shell

Most aren't related, but a couple are. I'm doing this in chunks to
avoid mongo-patches.

BUG=687660
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2761063002
Cr-Commit-Position: refs/heads/master@{#458242}
Committed: https://chromium.googlesource.com/chromium/src/+/79fa3471cea36082fa33d26b452878490b9cba84

[sky, 2017-03-20 21:26:30]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 21:27:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 21:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:31:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[msw, 2017-03-20 22:00:40]

lgtm with minor nits

https://codereview.chromium.org/2761063002/diff/20001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2761063002/diff/20001/ash/shell.h#newcode315
ash/shell.h:315: SystemTrayController* system_tray_controller() {
nit: these probably belong lower for abc ordering.

https://codereview.chromium.org/2761063002/diff/20001/ash/shell.h#newcode567
ash/shell.h:567: // TODO(msw|jamescook): Remove these once ShellDelegate, etc.
are ported.
nit: maybe keep this comment in WmShell?

[sky, 2017-03-20 22:06:23]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-20 22:06:24]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2761063002/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-03-20 22:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-20 22:07:38]

https://codereview.chromium.org/2761063002/diff/20001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2761063002/diff/20001/ash/shell.h#newcode315
ash/shell.h:315: SystemTrayController* system_tray_controller() {
On 2017/03/20 22:00:40, msw wrote:
> nit: these probably belong lower for abc ordering.

I think it's mostly a mess here and I'm holding off on reordering it all. For
example, tooltip_controller() shouldn't be before overlay_filter. Similarly the
members are all a jumble...

https://codereview.chromium.org/2761063002/diff/20001/ash/shell.h#newcode567
ash/shell.h:567: // TODO(msw|jamescook): Remove these once ShellDelegate, etc.
are ported.
On 2017/03/20 22:00:40, msw wrote:
> nit: maybe keep this comment in WmShell?

As discussed over IM I nuked the comment.

[commit-bot: I haz the power, 2017-03-20 23:46:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490047583588510,
"parent_rev": "3c7d798abb3a42da2bdaeeb0497a47575fda9bd2", "commit_rev":
"79fa3471cea36082fa33d26b452878490b9cba84"}

[commit-bot: I haz the power, 2017-03-20 23:47:45]

Description was changed from

==========
Move more from WmShell to Shell

Most aren't related, but a couple are. I'm doing this in chunks to
avoid mongo-patches.

BUG=687660
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Move more from WmShell to Shell

Most aren't related, but a couple are. I'm doing this in chunks to
avoid mongo-patches.

BUG=687660
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2761063002
Cr-Commit-Position: refs/heads/master@{#458242}
Committed:
https://chromium.googlesource.com/chromium/src/+/79fa3471cea36082fa33d26b4528...
==========

[commit-bot: I haz the power, 2017-03-20 23:47:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/79fa3471cea36082fa33d26b4528...