Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2761053002: Fix the NetLog to add end event for QUIC_SESSION (Closed)

Created:
3 years, 9 months ago by Zhongyi Shi
Modified:
3 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the NetLog to add end event for QUIC_SESSION in QuicChromiumClientSession destructor so that QUIC_SESSION will not be marked as active when the session is deleted. BUG=702909 Review-Url: https://codereview.chromium.org/2761053002 Cr-Commit-Position: refs/heads/master@{#458284} Committed: https://chromium.googlesource.com/chromium/src/+/27f1087519767c5ba6e57fae028435f4063f1bbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/chromium/quic_chromium_client_session.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Zhongyi Shi
3 years, 9 months ago (2017-03-20 21:11:04 UTC) #3
Ryan Hamilton
lgtm Nice catch. LGTM
3 years, 9 months ago (2017-03-20 21:34:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761053002/1
3 years, 9 months ago (2017-03-20 21:35:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/253937)
3 years, 9 months ago (2017-03-21 00:55:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761053002/1
3 years, 9 months ago (2017-03-21 00:56:30 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 02:37:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27f1087519767c5ba6e57fae0284...

Powered by Google App Engine
This is Rietveld 408576698