appcache content-type check

Require a specific content-type for appcache intercepts.

BUG=372634
TESTS=unittests and manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270036

[michaeln, 2014-05-12 21:51:32]

i'll update the CL to also put something on the console when INTERCEPT is
ignored

[darin (slow to review), 2014-05-12 23:45:32]

LGTM

https://codereview.chromium.org/276093003/diff/10001/webkit/browser/appcache/...
File webkit/browser/appcache/appcache_update_job.cc (right):

https://codereview.chromium.org/276093003/diff/10001/webkit/browser/appcache/...
webkit/browser/appcache/appcache_update_job.cc:497:
manifest_has_valid_mime_type_ = (mime_type == kManifestMimeType);
nit: I probably wouldn't have bothered with the named constant since it is only
referenced once.

https://codereview.chromium.org/276093003/diff/10001/webkit/browser/appcache/...
File webkit/browser/appcache/manifest_parser.h (right):

https://codereview.chromium.org/276093003/diff/10001/webkit/browser/appcache/...
webkit/browser/appcache/manifest_parser.h:61: bool allow_intercepts,
nit: I'm a fan of using enums in cases like these so the callsites are more
readable.

  ParseManifest(..., true, ...);
  ParseManifest(..., false, ...);

versus:

  ParseManifest(..., PARSE_MANIFEST_ALLOWING_INTERCEPTS, ...);
  ParseManifest(..., PARSE_MANIFEST_PER_STANDARD, ...);

[michaeln, 2014-05-13 00:38:00]

thnx

i updated the cl to also log a console message if/when INTERCEPTs are ignored

> manifest_has_valid_mime_type_ = (mime_type == kManifestMimeType);
> nit: I probably wouldn't have bothered with the named constant since it is
only
> referenced once.

done

> webkit/browser/appcache/manifest_parser.h:61: bool allow_intercepts,
> nit: I'm a fan of using enums in cases like these so the callsites are more
> readable.
> 
>   ParseManifest(..., true, ...);
>   ParseManifest(..., false, ...);
> 
> versus:
> 
>   ParseManifest(..., PARSE_MANIFEST_ALLOWING_INTERCEPTS, ...);
>   ParseManifest(..., PARSE_MANIFEST_PER_STANDARD, ...);

and done

[michaeln, 2014-05-13 00:52:03]

The CQ bit was checked by michaeln@chromium.org

[michaeln, 2014-05-13 00:52:07]

The CQ bit was unchecked by michaeln@chromium.org

[michaeln, 2014-05-13 01:34:43]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-05-13 01:36:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaeln@chromium.org/276093003/90001

[commit-bot: I haz the power, 2014-05-13 05:04:32]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[commit-bot: I haz the power, 2014-05-13 06:11:19]

Change committed as 270036