appcache content-type check

content/browser/appcache/manifest_parser_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 #include "webkit/browser/appcache/manifest_parser.h"
 
 using appcache::Manifest;
 using appcache::NamespaceVector;
 using appcache::FALLBACK_NAMESPACE;
 using appcache::INTERCEPT_NAMESPACE;
 using appcache::NETWORK_NAMESPACE;
+using appcache::PARSE_MANIFEST_ALLOWING_INTERCEPTS;
+using appcache::PARSE_MANIFEST_PER_STANDARD;
 
 namespace content {
 
 class AppCacheManifestParserTest : public testing::Test {
 };
 
 TEST(AppCacheManifestParserTest, NoData) {
   GURL url;
   Manifest manifest;
-  EXPECT_FALSE(ParseManifest(url, "", 0, manifest));
-  EXPECT_FALSE(ParseManifest(url, "CACHE MANIFEST\r", 0, manifest));  // 0 len
+  EXPECT_FALSE(ParseManifest(url, "", 0,
+                             PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
+  EXPECT_FALSE(ParseManifest(url, "CACHE MANIFEST\r", 0,  // Len is 0.
+                             PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
 }
 
 TEST(AppCacheManifestParserTest, CheckSignature) {
   GURL url;
   Manifest manifest;
 
   const std::string kBadSignatures[] = {
     "foo",
     "CACHE MANIFEST;V2\r",          // not followed by whitespace
     "CACHE MANIFEST#bad\r",         // no whitespace before comment
     "cache manifest ",              // wrong case
     "#CACHE MANIFEST\r",            // comment
     "xCACHE MANIFEST\n",            // bad first char
     " CACHE MANIFEST\r",            // begins with whitespace
     "\xEF\xBE\xBF" "CACHE MANIFEST\r",  // bad UTF-8 BOM value
   };
 
   for (size_t i = 0; i < arraysize(kBadSignatures); ++i) {
     const std::string bad = kBadSignatures[i];
-    EXPECT_FALSE(ParseManifest(url, bad.c_str(), bad.length(), manifest));
+    EXPECT_FALSE(ParseManifest(url, bad.c_str(), bad.length(),
+                               PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   }
 
   const std::string kGoodSignatures[] = {
     "CACHE MANIFEST",
     "CACHE MANIFEST ",
     "CACHE MANIFEST\r",
     "CACHE MANIFEST\n",
     "CACHE MANIFEST\r\n",
     "CACHE MANIFEST\t# ignore me\r",
     "CACHE MANIFEST ignore\r\n",
     "CHROMIUM CACHE MANIFEST\r\n",
     "\xEF\xBB\xBF" "CACHE MANIFEST \r\n",   // BOM present
   };
 
   for (size_t i = 0; i < arraysize(kGoodSignatures); ++i) {
     const std::string good = kGoodSignatures[i];
-    EXPECT_TRUE(ParseManifest(url, good.c_str(), good.length(), manifest));
+    EXPECT_TRUE(ParseManifest(url, good.c_str(), good.length(),
+                              PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   }
 }
 
 TEST(AppCacheManifestParserTest, NoManifestUrl) {
   Manifest manifest;
   const std::string kData("CACHE MANIFEST\r"
     "relative/tobase.com\r"
     "http://absolute.com/addme.com");
   const GURL kUrl;
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.explicit_urls.empty());
   EXPECT_TRUE(manifest.fallback_namespaces.empty());
   EXPECT_TRUE(manifest.online_whitelist_namespaces.empty());
   EXPECT_FALSE(manifest.online_whitelist_all);
 }
 
 TEST(AppCacheManifestParserTest, ExplicitUrls) {
   Manifest manifest;
   const GURL kUrl("http://www.foo.com");
   const std::string kData("CACHE MANIFEST\r"
     "relative/one\r"
     "# some comment\r"
     "http://www.foo.com/two#strip\r\n"
     "NETWORK:\r"
     "  \t CACHE:\r"
     "HTTP://www.diff.com/three\r"
     "FALLBACK:\r"
     " \t # another comment with leading whitespace\n"
     "IGNORE:\r"
     "http://www.foo.com/ignore\r"
     "CACHE: \r"
     "garbage:#!@\r"
     "https://www.foo.com/diffscheme \t \r"
     "  \t relative/four#stripme\n\r"
     "*\r");
 
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.fallback_namespaces.empty());
   EXPECT_TRUE(manifest.online_whitelist_namespaces.empty());
   EXPECT_FALSE(manifest.online_whitelist_all);
 
   base::hash_set<std::string> urls = manifest.explicit_urls;
   const size_t kExpected = 5;
   ASSERT_EQ(kExpected, urls.size());
   EXPECT_TRUE(urls.find("http://www.foo.com/relative/one") != urls.end());
   EXPECT_TRUE(urls.find("http://www.foo.com/two") != urls.end());
   EXPECT_TRUE(urls.find("http://www.diff.com/three") != urls.end());
   EXPECT_TRUE(urls.find("http://www.foo.com/relative/four") != urls.end());
 
   // Wildcard is treated as a relative URL in explicit section.
   EXPECT_TRUE(urls.find("http://www.foo.com/*") != urls.end());
+
+  // We should get the same results with intercepts disallowed.
+  manifest = Manifest();
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_PER_STANDARD, manifest));
+  EXPECT_TRUE(manifest.fallback_namespaces.empty());
+  EXPECT_TRUE(manifest.online_whitelist_namespaces.empty());
+  EXPECT_FALSE(manifest.online_whitelist_all);
+
+  urls = manifest.explicit_urls;
+  ASSERT_EQ(kExpected, urls.size());
+  EXPECT_TRUE(urls.find("http://www.foo.com/relative/one") != urls.end());
+  EXPECT_TRUE(urls.find("http://www.foo.com/two") != urls.end());
+  EXPECT_TRUE(urls.find("http://www.diff.com/three") != urls.end());
+  EXPECT_TRUE(urls.find("http://www.foo.com/relative/four") != urls.end());
+
+  // Wildcard is treated as a relative URL in explicit section.
+  EXPECT_TRUE(urls.find("http://www.foo.com/*") != urls.end());
 }
 
 TEST(AppCacheManifestParserTest, WhitelistUrls) {
   Manifest manifest;
   const GURL kUrl("http://www.bar.com");
   const std::string kData("CACHE MANIFEST\r"
     "NETWORK:\r"
     "relative/one\r"
     "# a comment\r"
     "http://www.bar.com/two\r"
     "HTTP://www.diff.com/three#strip\n\r"
     "FALLBACK:\r"
     "garbage\r"
     "UNKNOWN:\r"
     "http://www.bar.com/ignore\r"
     "CACHE:\r"
     "NETWORK:\r"
     "https://www.wrongscheme.com\n"
     "relative/four#stripref \t \r"
     "http://www.five.com\r\n"
     "*foo\r");
 
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.explicit_urls.empty());
   EXPECT_TRUE(manifest.fallback_namespaces.empty());
   EXPECT_TRUE(manifest.intercept_namespaces.empty());
   EXPECT_FALSE(manifest.online_whitelist_all);
 
   const NamespaceVector& online = manifest.online_whitelist_namespaces;
   const size_t kExpected = 6;
   ASSERT_EQ(kExpected, online.size());
   EXPECT_EQ(NETWORK_NAMESPACE, online[0].type);
   EXPECT_FALSE(online[0].is_pattern);
@@ skipping 25 matching lines @@
     "http://diff.com/ignore http://glorp.com/wronghost\r"
     "http://glorp.com/wronghost http://diff.com/ohwell\r"
     "relative/badscheme ftp://glorp.com/ignored\r"
     "garbage\r\n"
     "CACHE:\r"
     "# only fallback urls in this test\r"
     "FALLBACK:\n"
     "relative/four#strip relative/fourfb#strip\r"
     "http://www.glorp.com/notsame relative/skipped\r");
 
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.explicit_urls.empty());
   EXPECT_TRUE(manifest.online_whitelist_namespaces.empty());
   EXPECT_FALSE(manifest.online_whitelist_all);
 
   const NamespaceVector& fallbacks = manifest.fallback_namespaces;
   const size_t kExpected = 5;
   ASSERT_EQ(kExpected, fallbacks.size());
   EXPECT_EQ(FALLBACK_NAMESPACE, fallbacks[0].type);
   EXPECT_EQ(FALLBACK_NAMESPACE, fallbacks[1].type);
   EXPECT_EQ(FALLBACK_NAMESPACE, fallbacks[2].type);
@@ skipping 29 matching lines @@
   const std::string kData("CACHE MANIFEST\r"
     "FALLBACK:\r"
     "http://www.portme.com:1234/one relative/onefb\r"
     "HTTP://www.portme.com:9876/wrong http://www.portme.com:1234/ignore\r"
     "http://www.portme.com:1234/stillwrong http://www.portme.com:42/boo\r"
     "relative/two relative/twofb\r"
     "http://www.portme.com:1234/three HTTP://www.portme.com:1234/threefb\r"
     "http://www.portme.com/noport http://www.portme.com:1234/skipped\r"
     "http://www.portme.com:1234/skipme http://www.portme.com/noport\r");
 
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.explicit_urls.empty());
   EXPECT_TRUE(manifest.online_whitelist_namespaces.empty());
   EXPECT_FALSE(manifest.online_whitelist_all);
 
   const NamespaceVector& fallbacks = manifest.fallback_namespaces;
   const size_t kExpected = 3;
   ASSERT_EQ(kExpected, fallbacks.size());
   EXPECT_EQ(FALLBACK_NAMESPACE, fallbacks[0].type);
   EXPECT_EQ(FALLBACK_NAMESPACE, fallbacks[1].type);
   EXPECT_EQ(FALLBACK_NAMESPACE, fallbacks[2].type);
@@ skipping 21 matching lines @@
     "http://www.portme.com:1234/one return relative/int1\r"
     "HTTP://www.portme.com:9/wrong return http://www.portme.com:1234/ignore\r"
     "http://www.portme.com:1234/wrong return http://www.portme.com:9/boo\r"
     "relative/two return relative/int2\r"
     "relative/three wrong relative/threefb\r"
     "http://www.portme.com:1234/three return HTTP://www.portme.com:1234/int3\r"
     "http://www.portme.com/noport return http://www.portme.com:1234/skipped\r"
     "http://www.portme.com:1234/skipme return http://www.portme.com/noport\r"
     "relative/wrong/again missing/intercept_type\r");
 
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.fallback_namespaces.empty());
   EXPECT_TRUE(manifest.explicit_urls.empty());
   EXPECT_TRUE(manifest.online_whitelist_namespaces.empty());
   EXPECT_FALSE(manifest.online_whitelist_all);
 
   const NamespaceVector& intercepts = manifest.intercept_namespaces;
   const size_t kExpected = 3;
   ASSERT_EQ(kExpected, intercepts.size());
   EXPECT_EQ(INTERCEPT_NAMESPACE, intercepts[0].type);
   EXPECT_EQ(INTERCEPT_NAMESPACE, intercepts[1].type);
   EXPECT_EQ(INTERCEPT_NAMESPACE, intercepts[2].type);
   EXPECT_EQ(GURL("http://www.portme.com:1234/one"),
             intercepts[0].namespace_url);
   EXPECT_EQ(GURL("http://www.portme.com:1234/relative/int1"),
             intercepts[0].target_url);
   EXPECT_EQ(GURL("http://www.portme.com:1234/relative/two"),
             intercepts[1].namespace_url);
   EXPECT_EQ(GURL("http://www.portme.com:1234/relative/int2"),
             intercepts[1].target_url);
   EXPECT_EQ(GURL("http://www.portme.com:1234/three"),
             intercepts[2].namespace_url);
   EXPECT_EQ(GURL("http://www.portme.com:1234/int3"),
             intercepts[2].target_url);
+
+  // Disallow intercepts ths time.
+  manifest = Manifest();
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_PER_STANDARD, manifest));
+  EXPECT_TRUE(manifest.fallback_namespaces.empty());
+  EXPECT_TRUE(manifest.explicit_urls.empty());
+  EXPECT_TRUE(manifest.online_whitelist_namespaces.empty());
+  EXPECT_TRUE(manifest.intercept_namespaces.empty());
+  EXPECT_FALSE(manifest.online_whitelist_all);
 }
 
 TEST(AppCacheManifestParserTest, ComboUrls) {
   Manifest manifest;
   const GURL kUrl("http://combo.com:42");
   const std::string kData("CACHE MANIFEST\r"
     "relative/explicit-1\r"
     "# some comment\r"
     "http://combo.com:99/explicit-2#strip\r"
     "NETWORK:\r"
     "http://combo.com/whitelist-1\r"
     "HTTP://www.diff.com/whitelist-2#strip\r"
     "*\r"
     "CACHE:\n\r"
     "http://www.diff.com/explicit-3\r"
     "FALLBACK:\r"
     "http://combo.com:42/fallback-1 http://combo.com:42/fallback-1b\r"
     "relative/fallback-2 relative/fallback-2b\r"
     "UNKNOWN:\r\n"
     "http://combo.com/ignoreme\r"
     "relative/still-ignored\r"
     "NETWORK:\r\n"
     "relative/whitelist-3#strip\r"
     "http://combo.com:99/whitelist-4\r");
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.online_whitelist_all);
 
   base::hash_set<std::string> urls = manifest.explicit_urls;
   size_t expected = 3;
   ASSERT_EQ(expected, urls.size());
   EXPECT_TRUE(urls.find("http://combo.com:42/relative/explicit-1") !=
               urls.end());
   EXPECT_TRUE(urls.find("http://combo.com:99/explicit-2") != urls.end());
   EXPECT_TRUE(urls.find("http://www.diff.com/explicit-3") != urls.end());
 
@@ skipping 25 matching lines @@
 
   EXPECT_TRUE(manifest.intercept_namespaces.empty());
 }
 
 TEST(AppCacheManifestParserTest, UnusualUtf8) {
   Manifest manifest;
   const GURL kUrl("http://bad.com");
   const std::string kData("CACHE MANIFEST\r"
     "\xC0" "invalidutf8\r"
     "nonbmp" "\xF1\x84\xAB\xBC\r");
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
-
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   base::hash_set<std::string> urls = manifest.explicit_urls;
   EXPECT_TRUE(urls.find("http://bad.com/%EF%BF%BDinvalidutf8") != urls.end());
   EXPECT_TRUE(urls.find("http://bad.com/nonbmp%F1%84%AB%BC") != urls.end());
 }
 
 TEST(AppCacheManifestParserTest, IgnoreAfterSpace) {
   Manifest manifest;
   const GURL kUrl("http://smorg.borg");
   const std::string kData(
     "CACHE MANIFEST\r"
     "resource.txt this stuff after the white space should be ignored\r");
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
 
   base::hash_set<std::string> urls = manifest.explicit_urls;
   EXPECT_TRUE(urls.find("http://smorg.borg/resource.txt") != urls.end());
 }
 
 TEST(AppCacheManifestParserTest, DifferentOriginUrlWithSecureScheme) {
   Manifest manifest;
   const GURL kUrl("https://www.foo.com");
   const std::string kData("CACHE MANIFEST\r"
     "CACHE: \r"
     "relative/secureschemesameorigin\r"
     "https://www.foo.com/secureschemesameorigin\r"
     "http://www.xyz.com/secureschemedifforigin\r"
     "https://www.xyz.com/secureschemedifforigin\r");
 
-  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest));
+  EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.fallback_namespaces.empty());
   EXPECT_TRUE(manifest.online_whitelist_namespaces.empty());
 
   base::hash_set<std::string> urls = manifest.explicit_urls;
   const size_t kExpected = 3;
   ASSERT_EQ(kExpected, urls.size());
   EXPECT_TRUE(urls.find("https://www.foo.com/relative/secureschemesameorigin")
       != urls.end());
   EXPECT_TRUE(urls.find("https://www.foo.com/secureschemesameorigin") !=
       urls.end());
@@ skipping 17 matching lines @@
       "http://foo.com/fallback_prefix  /prefix wrongAnnotation\r"
       "http://foo.com/fallback_pattern* /pattern\tisPattern    \r"
       "NETWORK:\r"
       "*\r"
       "isPattern\r"  // should not be interpretted as a pattern
       "http://foo.com/network_pattern* isPattern\r");
 
 
   Manifest manifest;
   EXPECT_TRUE(ParseManifest(kUrl, kManifestBody.c_str(),
-                            kManifestBody.length(), manifest));
+                            kManifestBody.length(),
+                            PARSE_MANIFEST_ALLOWING_INTERCEPTS, manifest));
   EXPECT_TRUE(manifest.online_whitelist_all);
   EXPECT_EQ(1u, manifest.explicit_urls.size());
   EXPECT_EQ(3u, manifest.intercept_namespaces.size());
   EXPECT_EQ(2u, manifest.fallback_namespaces.size());
   EXPECT_EQ(2u, manifest.online_whitelist_namespaces.size());
   EXPECT_EQ(INTERCEPT_NAMESPACE, manifest.intercept_namespaces[0].type);
   EXPECT_EQ(FALLBACK_NAMESPACE, manifest.fallback_namespaces[0].type);
   EXPECT_EQ(NETWORK_NAMESPACE, manifest.online_whitelist_namespaces[0].type);
   EXPECT_FALSE(manifest.intercept_namespaces[0].is_pattern);
   EXPECT_TRUE(manifest.intercept_namespaces[1].is_pattern);
@@ skipping 22 matching lines @@
       manifest.online_whitelist_namespaces[0].target_url);
   EXPECT_EQ(
       GURL("http://foo.com/network_pattern*"),
       manifest.online_whitelist_namespaces[1].namespace_url);
   EXPECT_EQ(
       GURL(),
       manifest.online_whitelist_namespaces[1].target_url);
 }
 
 }  // namespace content