build/android/gyp/push_libraries.py - Issue 2760923002: [build/android] Fix device.RunShellCommand usages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/push_libraries.py

Issue 2760923002: [build/android] Fix device.RunShellCommand usages (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/push_libraries.py

diff --git a/build/android/gyp/push_libraries.py b/build/android/gyp/push_libraries.py

index 7d904430ccc3f18fd430dc67f1ccb84c637d5056..1a64f3dc9b0514d74485da575d703cfb823e3088 100755

--- a/build/android/gyp/push_libraries.py

+++ b/build/android/gyp/push_libraries.py

@@ -40,7 +40,8 @@ def DoPush(options):

def Push():

if needs_directory:

- device.RunShellCommand('mkdir -p ' + options.device_dir)

+ device.RunShellCommand(

+ ['mkdir', '-p', options.device_dir], check_return=True)

needs_directory[:] = [] # = False

device.PushChangedFiles([(os.path.abspath(host_path), device_path)])