Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2760903003: [Autofill] Save billing address changes for server cards on android. (Closed)

Created:
3 years, 9 months ago by sebsg
Modified:
3 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Save billing address changes for server cards on android. BUG=703280 Review-Url: https://codereview.chromium.org/2760903003 Cr-Commit-Position: refs/heads/master@{#458462} Committed: https://chromium.googlesource.com/chromium/src/+/1990dda534f52804f74fe74c749301ca1f937dd3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sebsg
Hi Dan, could you please take a look? Thanks!
3 years, 9 months ago (2017-03-20 19:30:02 UTC) #2
gone
https://codereview.chromium.org/2760903003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java (right): https://codereview.chromium.org/2760903003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java#newcode94 chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java:94: mCard.setBillingAddressId(((AutofillProfile) mBillingAddress.getSelectedItem()).getGUID()); getSelectedItem can return null.
3 years, 9 months ago (2017-03-20 20:35:23 UTC) #3
sebsg
Thanks you, sorry for that. Another look? https://codereview.chromium.org/2760903003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java (right): https://codereview.chromium.org/2760903003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java#newcode94 chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java:94: mCard.setBillingAddressId(((AutofillProfile) mBillingAddress.getSelectedItem()).getGUID()); ...
3 years, 9 months ago (2017-03-21 16:04:28 UTC) #5
gone
lgtm
3 years, 9 months ago (2017-03-21 16:59:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760903003/40001
3 years, 9 months ago (2017-03-21 17:00:54 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 17:44:03 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1990dda534f52804f74fe74c7493...

Powered by Google App Engine
This is Rietveld 408576698