Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2760893003: Update new VP9 codec string parsing (Closed)

Created:
3 years, 9 months ago by chcunningham
Modified:
3 years, 9 months ago
Reviewers:
hubbe
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update new VP9 codec string parsing To reflect latest proposal (move chroma subsampling) and fix a bug in parsing of level (Level 1 is "10", not "01" - multiplied by 10 to accodate notation of fractional levels (1.1 is "11")). BUG=687627 TEST=fix media_unittests Review-Url: https://codereview.chromium.org/2760893003 Cr-Commit-Position: refs/heads/master@{#458489} Committed: https://chromium.googlesource.com/chromium/src/+/d6bc1395974d40370fdb9ccca384e09ade253d1b

Patch Set 1 #

Patch Set 2 : Fix browsertest #

Patch Set 3 : Fix media unittests #

Patch Set 4 : So many tests... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -107 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 9 chunks +13 lines, -13 lines 0 comments Download
M media/base/mime_util_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/video_codecs.cc View 3 chunks +30 lines, -27 lines 0 comments Download
M media/base/video_codecs_unittest.cc View 2 chunks +56 lines, -56 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (14 generated)
chcunningham
3 years, 9 months ago (2017-03-20 21:22:54 UTC) #2
hubbe
lgtm
3 years, 9 months ago (2017-03-20 21:40:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760893003/1
3 years, 9 months ago (2017-03-20 21:47:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/330272)
3 years, 9 months ago (2017-03-20 22:23:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760893003/20001
3 years, 9 months ago (2017-03-20 22:41:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760893003/40001
3 years, 9 months ago (2017-03-20 23:02:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/412604)
3 years, 9 months ago (2017-03-21 00:30:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760893003/60001
3 years, 9 months ago (2017-03-21 01:56:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/343951)
3 years, 9 months ago (2017-03-21 02:54:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760893003/60001
3 years, 9 months ago (2017-03-21 17:17:20 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 18:44:56 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d6bc1395974d40370fdb9ccca384...

Powered by Google App Engine
This is Rietveld 408576698