Chromium Code Reviews
Description[Merge to M-58] [Password Manager] Fix saving for accounts.google.com.
Saving on accounts.google.com doesn't work, the reasons are the following:
The sign-in form is loaded on https://accounts.google.com/ServiceLogin, but then when the submission is done, url is https://accounts.google.com/signin/v2/challenge/pwd , so loaded form and the submitted form are considered as different forms, and the Password Manager thinks that the submitted form was not seen during adding to DOM, and such forms are skipped since Password Manager can't fill forms that can't be seen (and no point to save password, that can't be filled). But this is legitimate site behaviour
This CL implements checking whether loaded and submitted forms come from the same frame (a frame is represented with a driver in Password Manager code).
BUG=699097
Review-Url: https://codereview.chromium.org/2740523002
Cr-Commit-Position: refs/heads/master@{#456674}
(cherry picked from commit 411333039edf0a1cfa7ecd505a979af3015545f2)
Review-Url: https://codereview.chromium.org/2760883002 .
Cr-Commit-Position: refs/branch-heads/3029@{#293}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/5083384086d0a831786ccd7c6a9ee55d4ca85ef3
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||