Remove use of PRODUCT_STRING_PATH in chrome_elf.

Remove use of PRODUCT_STRING_PATH in chrome_elf.

The blacklist and browser security code now use install_static's
GetRegistryPath function to get the brand- and install mode-specific
path to a spot in the registry for various data stuffage.

BUG=577820, 650982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2760853002
Cr-Commit-Position: refs/heads/master@{#461064}
Committed: https://chromium.googlesource.com/chromium/src/+/b4cab81eb31fc479ab7583d6cbfab9288750aeb5

[grt (UTC plus 2), 2017-03-20 11:11:13]

Description was changed from

==========
Remove use of PRODUCT_STRING_PATH in chrome_elf.

The blacklist and browser security code now use install_static's
GetRegistryPath function to get the brand- and install mode-specific
path to a spot in the registry for various data stuffage.

BUG=577820,650982
==========

to

==========
Remove use of PRODUCT_STRING_PATH in chrome_elf.

The blacklist and browser security code now use install_static's
GetRegistryPath function to get the brand- and install mode-specific
path to a spot in the registry for various data stuffage.

BUG=577820,650982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[grt (UTC plus 2), 2017-03-20 11:12:43]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 11:12:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-03-20 11:14:31]

grt@chromium.org changed reviewers:
+ csharp@chromium.org, pennymac@chromium.org

[grt (UTC plus 2), 2017-03-20 11:14:32]

PTAL.

pennymac: I also deleted what appeared to be an unused constant in elf_sec. Did
that serve a purpose? Would you like me to add it back as a key name constant?

[commit-bot: I haz the power, 2017-03-20 11:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 11:44:47]

Dry run: Try jobs failed on following builders:
  win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...)

[grt (UTC plus 2), 2017-03-20 12:55:20]

https://codereview.chromium.org/2760853002/diff/1/chrome/browser/win/chrome_e...
File chrome/browser/win/chrome_elf_init.cc (right):

https://codereview.chromium.org/2760853002/diff/1/chrome/browser/win/chrome_e...
chrome/browser/win/chrome_elf_init.cc:137: blacklist::kRegistryBeaconPath,
oops, missed this one. will address in the next patch set

[csharp, 2017-03-20 13:31:45]

lgtm

[grt (UTC plus 2), 2017-03-20 20:10:37]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 20:11:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-03-20 20:13:36]

Thanks.

https://codereview.chromium.org/2760853002/diff/1/chrome/browser/win/chrome_e...
File chrome/browser/win/chrome_elf_init.cc (right):

https://codereview.chromium.org/2760853002/diff/1/chrome/browser/win/chrome_e...
chrome/browser/win/chrome_elf_init.cc:137: blacklist::kRegistryBeaconPath,
On 2017/03/20 12:55:20, grt (UTC plus 1) wrote:
> oops, missed this one. will address in the next patch set

Done.

https://codereview.chromium.org/2760853002/diff/20001/chrome_elf/BUILD.gn
File chrome_elf/BUILD.gn (right):

https://codereview.chromium.org/2760853002/diff/20001/chrome_elf/BUILD.gn#new...
chrome_elf/BUILD.gn:82: "//chrome/install_static:install_static_util",
pennymac: if you'd prefer to avoid this dependency, i could add the reg path as
an in-param to EarlyBrowserSecurity(). i don't see that it matters, since
install_static must be initialized before EBS is called anyway. curious to hear
your thoughts. maybe you have another idea? thanks for taking a look.

[commit-bot: I haz the power, 2017-03-20 20:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:49:56]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[grt (UTC plus 2), 2017-03-20 21:42:44]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 21:43:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:22:26]

Dry run: Try jobs failed on following builders:
  win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...)

[grt (UTC plus 2), 2017-03-21 06:25:30]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 06:25:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 07:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 07:06:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[grt (UTC plus 2), 2017-03-21 07:48:19]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 07:48:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-03-21 07:48:43]

Patchset #4 (id:60001) has been deleted

[grt (UTC plus 2), 2017-03-21 07:49:30]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-03-21 09:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 09:23:06]

Dry run: Try jobs failed on following builders:
  win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...)

[grt (UTC plus 2), 2017-03-21 10:19:11]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 10:19:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 11:20:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 11:20:43]

Dry run: This issue passed the CQ dry run.

[penny, 2017-03-30 18:16:27]

On 2017/03/20 20:13:36, grt (UTC plus 2) wrote:
> Thanks.
> 
>
https://codereview.chromium.org/2760853002/diff/1/chrome/browser/win/chrome_e...
> File chrome/browser/win/chrome_elf_init.cc (right):
> 
>
https://codereview.chromium.org/2760853002/diff/1/chrome/browser/win/chrome_e...
> chrome/browser/win/chrome_elf_init.cc:137: blacklist::kRegistryBeaconPath,
> On 2017/03/20 12:55:20, grt (UTC plus 1) wrote:
> > oops, missed this one. will address in the next patch set
> 
> Done.
> 
> https://codereview.chromium.org/2760853002/diff/20001/chrome_elf/BUILD.gn
> File chrome_elf/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2760853002/diff/20001/chrome_elf/BUILD.gn#new...
> chrome_elf/BUILD.gn:82: "//chrome/install_static:install_static_util",
> pennymac: if you'd prefer to avoid this dependency, i could add the reg path
as
> an in-param to EarlyBrowserSecurity(). i don't see that it matters, since
> install_static must be initialized before EBS is called anyway. curious to
hear
> your thoughts. maybe you have another idea? thanks for taking a look.

LGTM

Nice cleanup Greg.  Great to not have to check branding everywhere.  :)
I'm fine with the new dep... as long as install_static stays small and continues
to only use kernel32.dll (which it should).

Thanks!

[grt (UTC plus 2), 2017-03-31 05:46:00]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-03-31 05:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org
Link to the patchset: https://codereview.chromium.org/2760853002/#ps80001
(title: "now")

[commit-bot: I haz the power, 2017-03-31 05:46:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 06:58:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490939160634040,
"parent_rev": "2117819019ac819cb1beec1647f6aed74d7fb850", "commit_rev":
"b4cab81eb31fc479ab7583d6cbfab9288750aeb5"}

[commit-bot: I haz the power, 2017-03-31 06:59:37]

Description was changed from

==========
Remove use of PRODUCT_STRING_PATH in chrome_elf.

The blacklist and browser security code now use install_static's
GetRegistryPath function to get the brand- and install mode-specific
path to a spot in the registry for various data stuffage.

BUG=577820,650982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Remove use of PRODUCT_STRING_PATH in chrome_elf.

The blacklist and browser security code now use install_static's
GetRegistryPath function to get the brand- and install mode-specific
path to a spot in the registry for various data stuffage.

BUG=577820,650982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2760853002
Cr-Commit-Position: refs/heads/master@{#461064}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4cab81eb31fc479ab7583d6cbfa...
==========

[commit-bot: I haz the power, 2017-03-31 06:59:39]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b4cab81eb31fc479ab7583d6cbfa...