Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2760803002:
Set limit on maximum width of ChromeVox menus. (Closed)
|
Created:
3 years, 9 months ago by dmazzoni Modified:
3 years, 9 months ago Reviewers:
David Tseng CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSet limit on maximum width of ChromeVox menus.
The auto-generated ChromeVox menus like the list of headings or links
often contain long strings or urls, which were causing the ChromeVox menus
to extend past the width of the screen. Fix this with some simple CSS that
sets a maximum width for the menu title, makes it stay on a single line and
not auto-wrap, and then uses ellipses to visually show if the whole title
doesn't fit.
BUG=672941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2760803002
Cr-Commit-Position: refs/heads/master@{#458926}
Committed: https://chromium.googlesource.com/chromium/src/+/130aefc5b0d01ced8a2dc0b17db8179d422ac526
Patch Set 1 #Patch Set 2 : Fix closure compile errors #Patch Set 3 : Rebase #
Messages
Total messages: 26 (15 generated)
Description was changed from ========== Set limit on maximum width of ChromeVox menus. The auto-generated ChromeVox menus like the list of headings or links often contain long strings or urls, which were causing the ChromeVox menus to extend past the width of the screen. Fix this with some simple CSS that sets a maximum width for the menu title, makes it stay on a single line and not auto-wrap, and then uses ellipses to visually show if the whole title doesn't fit. BUG=672941 ========== to ========== Set limit on maximum width of ChromeVox menus. The auto-generated ChromeVox menus like the list of headings or links often contain long strings or urls, which were causing the ChromeVox menus to extend past the width of the screen. Fix this with some simple CSS that sets a maximum width for the menu title, makes it stay on a single line and not auto-wrap, and then uses ellipses to visually show if the whole title doesn't fit. BUG=672941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dmazzoni@chromium.org changed reviewers: + dtseng@chromium.org
lgtm, thanks. How about also shoing the full text on mouse hover (i.e.. title attribute)?
On 2017/03/20 16:46:00, David Tseng wrote: > lgtm, thanks. How about also shoing the full text on mouse hover (i.e.. title > attribute)? Would ChromeVox read it twice? I guess if so that'd be worth fixing.
On 2017/03/20 16:48:06, dmazzoni wrote: > On 2017/03/20 16:46:00, David Tseng wrote: > > lgtm, thanks. How about also shoing the full text on mouse hover (i.e.. title > > attribute)? > > Would ChromeVox read it twice? I guess if so that'd be worth fixing. Does title come through as description? We explicitly drop description if it dups name.
Yes, it comes through as description, and you're right. Doesn't read it twice. On Mon, Mar 20, 2017 at 9:56 AM <dtseng@chromium.org> wrote: > On 2017/03/20 16:48:06, dmazzoni wrote: > > On 2017/03/20 16:46:00, David Tseng wrote: > > > lgtm, thanks. How about also shoing the full text on mouse hover (i.e.. > title > > > attribute)? > > > > Would ChromeVox read it twice? I guess if so that'd be worth fixing. > > Does title come through as description? We explicitly drop description if > it > dups name. > > > https://codereview.chromium.org/2760803002/ > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to chromium-reviews+unsubscribe@chromium.org. > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by dmazzoni@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org Link to the patchset: https://codereview.chromium.org/2760803002/#ps20001 (title: "Fix closure compile errors")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dmazzoni@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org Link to the patchset: https://codereview.chromium.org/2760803002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490221000779480,
"parent_rev": "be50046d5ab84d12920bfab89131506f002aab11", "commit_rev":
"130aefc5b0d01ced8a2dc0b17db8179d422ac526"}
Message was sent while issue was closed.
Description was changed from ========== Set limit on maximum width of ChromeVox menus. The auto-generated ChromeVox menus like the list of headings or links often contain long strings or urls, which were causing the ChromeVox menus to extend past the width of the screen. Fix this with some simple CSS that sets a maximum width for the menu title, makes it stay on a single line and not auto-wrap, and then uses ellipses to visually show if the whole title doesn't fit. BUG=672941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Set limit on maximum width of ChromeVox menus. The auto-generated ChromeVox menus like the list of headings or links often contain long strings or urls, which were causing the ChromeVox menus to extend past the width of the screen. Fix this with some simple CSS that sets a maximum width for the menu title, makes it stay on a single line and not auto-wrap, and then uses ellipses to visually show if the whole title doesn't fit. BUG=672941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2760803002 Cr-Commit-Position: refs/heads/master@{#458926} Committed: https://chromium.googlesource.com/chromium/src/+/130aefc5b0d01ced8a2dc0b17db8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/130aefc5b0d01ced8a2dc0b17db8... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
