Reland: add voice interaction shortcut.

Reland: add voice interaction shortcut.

Reviewed at: https://codereview.chromium.org/2731403007/
Bug: 699309
Test: Meta + a starts voice interaction session
  in CrOS.

Review-Url: https://codereview.chromium.org/2760773002
Cr-Commit-Position: refs/heads/master@{#458290}
Committed: https://chromium.googlesource.com/chromium/src/+/cc1c52789b126b191dcfc7258e752de7e3cff549

[Muyuan, 2017-03-19 02:04:02]

muyuanli@chromium.org changed reviewers:
+ dcheng@chromium.org, lhchavez@chromium.org

[Muyuan, 2017-03-19 02:10:36]

The CQ bit was checked by muyuanli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-19 02:10:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-03-19 02:38:40]

Note: for relands, please upload the original diff as PS1 and the updated diff
as PS2. It makes it easier to review.

[commit-bot: I haz the power, 2017-03-19 04:33:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 04:33:40]

Dry run: This issue passed the CQ dry run.

[Muyuan, 2017-03-19 22:36:42]

On 2017/03/19 02:38:40, dcheng wrote:
> Note: for relands, please upload the original diff as PS1 and the updated diff
> as PS2. It makes it easier to review.

done. Please see the difference between patchset 2 and 3.

[Muyuan, 2017-03-19 22:36:44]

On 2017/03/19 02:38:40, dcheng wrote:
> Note: for relands, please upload the original diff as PS1 and the updated diff
> as PS2. It makes it easier to review.

done. Please see the difference between patchset 2 and 3.

[Muyuan, 2017-03-19 22:37:17]

The CQ bit was checked by muyuanli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-19 22:37:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-19 23:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 23:50:14]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dcheng, 2017-03-20 02:51:39]

LGTM, thanks!

[Luis Héctor Chávez, 2017-03-20 15:03:07]

Just for completeness, can you run the build with the exact same configuration
as
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
(in particular
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...
)?

i.e.

cat > out/Debug/args.gn <<EOF
ffmpeg_branding = "ChromeOS"
is_component_build = true
is_debug = true
proprietary_codecs = true
target_os = "chromeos"
use_goma = true
EOF
ninja -C out/Debug accessibility_unittests accessibility_unittests_run
app_list_presenter_unittests app_list_presenter_unittests_run app_list_unittests
app_list_unittests_run app_shell_unittests app_shell_unittests_run
ash_content_unittests ash_content_unittests_run ash_unittests ash_unittests_run
aura_builder aura_unittests aura_unittests_run base_unittests base_unittests_run
browser_tests browser_tests_run cacheinvalidation_unittests
cacheinvalidation_unittests_run capture_unittests capture_unittests_run
chrome_app_unittests chrome_app_unittests_run chromeos_unittests
chromeos_unittests_run components_unittests components_unittests_run
compositor_unittests compositor_unittests_run content_browsertests
content_browsertests_run content_unittests content_unittests_run
crypto_unittests crypto_unittests_run device_unittests device_unittests_run
display_unittests display_unittests_run events_unittests events_unittests_run
extensions_browsertests extensions_browsertests_run extensions_unittests
extensions_unittests_run gcm_unit_tests gcm_unit_tests_run gfx_unittests
gfx_unittests_run google_apis_unittests google_apis_unittests_run
gpu_ipc_service_unittests gpu_ipc_service_unittests_run gpu_unittests
gpu_unittests_run interactive_ui_tests interactive_ui_tests_run ipc_tests
ipc_tests_run jingle_unittests jingle_unittests_run media_blink_unittests
media_blink_unittests_run media_unittests media_unittests_run
message_center_unittests message_center_unittests_run midi_unittests
midi_unittests_run nacl_helper_nonsfi_unittests nacl_helper_nonsfi_unittests_run
nacl_loader_unittests nacl_loader_unittests_run native_theme_unittests
native_theme_unittests_run net_unittests net_unittests_run pdf_unittests
pdf_unittests_run ppapi_unittests ppapi_unittests_run remoting_unittests
remoting_unittests_run sandbox_linux_unittests sandbox_linux_unittests_run
service_unittests service_unittests_run skia_unittests skia_unittests_run
sql_unittests sql_unittests_run storage_unittests storage_unittests_run
sync_integration_tests sync_integration_tests_run ui_arc_unittests
ui_arc_unittests_run ui_base_unittests ui_base_unittests_run
ui_chromeos_unittests ui_chromeos_unittests_run ui_touch_selection_unittests
ui_touch_selection_unittests_run unit_tests unit_tests_run url_unittests
url_unittests_run views_unittests views_unittests_run wm_unittests
wm_unittests_run

[Muyuan, 2017-03-20 21:10:55]

On 2017/03/20 15:03:07, Luis Héctor Chávez wrote:
> Just for completeness, can you run the build with the exact same configuration
> as
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> (in particular
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...
> )?
> 
> i.e.
> 
> cat > out/Debug/args.gn <<EOF
> ffmpeg_branding = "ChromeOS"
> is_component_build = true
> is_debug = true
> proprietary_codecs = true
> target_os = "chromeos"
> use_goma = true
> EOF
> ninja -C out/Debug accessibility_unittests accessibility_unittests_run
> app_list_presenter_unittests app_list_presenter_unittests_run
app_list_unittests
> app_list_unittests_run app_shell_unittests app_shell_unittests_run
> ash_content_unittests ash_content_unittests_run ash_unittests
ash_unittests_run
> aura_builder aura_unittests aura_unittests_run base_unittests
base_unittests_run
> browser_tests browser_tests_run cacheinvalidation_unittests
> cacheinvalidation_unittests_run capture_unittests capture_unittests_run
> chrome_app_unittests chrome_app_unittests_run chromeos_unittests
> chromeos_unittests_run components_unittests components_unittests_run
> compositor_unittests compositor_unittests_run content_browsertests
> content_browsertests_run content_unittests content_unittests_run
> crypto_unittests crypto_unittests_run device_unittests device_unittests_run
> display_unittests display_unittests_run events_unittests events_unittests_run
> extensions_browsertests extensions_browsertests_run extensions_unittests
> extensions_unittests_run gcm_unit_tests gcm_unit_tests_run gfx_unittests
> gfx_unittests_run google_apis_unittests google_apis_unittests_run
> gpu_ipc_service_unittests gpu_ipc_service_unittests_run gpu_unittests
> gpu_unittests_run interactive_ui_tests interactive_ui_tests_run ipc_tests
> ipc_tests_run jingle_unittests jingle_unittests_run media_blink_unittests
> media_blink_unittests_run media_unittests media_unittests_run
> message_center_unittests message_center_unittests_run midi_unittests
> midi_unittests_run nacl_helper_nonsfi_unittests
nacl_helper_nonsfi_unittests_run
> nacl_loader_unittests nacl_loader_unittests_run native_theme_unittests
> native_theme_unittests_run net_unittests net_unittests_run pdf_unittests
> pdf_unittests_run ppapi_unittests ppapi_unittests_run remoting_unittests
> remoting_unittests_run sandbox_linux_unittests sandbox_linux_unittests_run
> service_unittests service_unittests_run skia_unittests skia_unittests_run
> sql_unittests sql_unittests_run storage_unittests storage_unittests_run
> sync_integration_tests sync_integration_tests_run ui_arc_unittests
> ui_arc_unittests_run ui_base_unittests ui_base_unittests_run
> ui_chromeos_unittests ui_chromeos_unittests_run ui_touch_selection_unittests
> ui_touch_selection_unittests_run unit_tests unit_tests_run url_unittests
> url_unittests_run views_unittests views_unittests_run wm_unittests
> wm_unittests_run

Thx. Locally tested and it works.

[Luis Héctor Chávez, 2017-03-20 21:16:38]

thanks for checking. unfortunately the build stops at the first error so we need
to be extra careful.

lgtm

[Muyuan, 2017-03-20 21:18:40]

The CQ bit was checked by muyuanli@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:19:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Muyuan, 2017-03-20 21:42:30]

The CQ bit was unchecked by muyuanli@chromium.org

[Muyuan, 2017-03-20 23:46:34]

The CQ bit was checked by muyuanli@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:47:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 03:06:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490053594808000,
"parent_rev": "d4feda275fb027a97d261733f28109775c23ebe6", "commit_rev":
"cc1c52789b126b191dcfc7258e752de7e3cff549"}

[commit-bot: I haz the power, 2017-03-21 03:08:16]

Description was changed from

==========
Reland: add voice interaction shortcut.

Reviewed at: https://codereview.chromium.org/2731403007/
Bug: 699309
Test: Meta + a starts voice interaction session
  in CrOS.
==========

to

==========
Reland: add voice interaction shortcut.

Reviewed at: https://codereview.chromium.org/2731403007/
Bug: 699309
Test: Meta + a starts voice interaction session
  in CrOS.

Review-Url: https://codereview.chromium.org/2760773002
Cr-Commit-Position: refs/heads/master@{#458290}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc1c52789b126b191dcfc7258e75...
==========

[commit-bot: I haz the power, 2017-03-21 03:08:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cc1c52789b126b191dcfc7258e75...