Check for already existing entry when adding to SiteProcessMap.

Check for already existing entry when adding to SiteProcessMap.

The SiteProcessMap::RegisterProcess can overwrite existing entries
in the map, which can lead to incorrect process being mapped to
a site in process-per-site mode. This CL checks for existence and
avoids the overwrite.

This CL is a reland of https://codereview.chromium.org/2739193004/
after the flaky test was fixed in https://codereview.chromium.org/2754173003/

BUG=700514
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2760733002
Cr-Commit-Position: refs/heads/master@{#457925}
Committed: https://chromium.googlesource.com/chromium/src/+/d1aaa76016c981807fbe10c53c00de6061200c98

[nasko, 2017-03-17 22:00:11]

Description was changed from

==========
Check for already existing entry when adding to SiteProcessMap.

The SiteProcessMap::RegisterProcess can overwrite existing entries
in the map, which can lead to incorrect process being mapped to
a site in process-per-site mode. This CL checks for existence and
avoids the overwrite.

This CL is a reland of https://codereview.chromium.org/2739193004/
after the flaky test was fixed in https://codereview.chromium.org/2754173003/

BUG=700514
==========

to

==========
Check for already existing entry when adding to SiteProcessMap.

The SiteProcessMap::RegisterProcess can overwrite existing entries
in the map, which can lead to incorrect process being mapped to
a site in process-per-site mode. This CL checks for existence and
avoids the overwrite.

This CL is a reland of https://codereview.chromium.org/2739193004/
after the flaky test was fixed in https://codereview.chromium.org/2754173003/

BUG=700514
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2017-03-17 22:08:43]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 22:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2017-03-17 22:10:35]

nasko@chromium.org changed reviewers:
+ creis@chromium.org, rdevlin.cronin@chromium.org

[nasko, 2017-03-17 22:10:35]

Hey Charlie and Devlin,
This is a reland of my previous CL to fix the SiteProcessMap issue. I've also
added reverting of the test case ordering I had to do, otherwise it is
identical.
engedy@ was awesomely helpful to deflake the test that failed with this CL, so
we should be good to go now :) (famous last word).

Could you review/stamp this CL?
Thanks in advance!
Nasko

[Charlie Reis, 2017-03-17 22:13:10]

Great!  RS LGTM.

[Devlin, 2017-03-17 22:15:16]

Woohoo!  Thanks for the speedy turnaround.  RS LGTM

[commit-bot: I haz the power, 2017-03-18 01:46:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 01:46:15]

Dry run: This issue passed the CQ dry run.

[nasko, 2017-03-18 02:09:29]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2017-03-18 02:10:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:14:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489802969562850,
"parent_rev": "1d011954aa1b2ce52a743a92b89e3291c39a7759", "commit_rev":
"d1aaa76016c981807fbe10c53c00de6061200c98"}

[commit-bot: I haz the power, 2017-03-18 02:15:31]

Description was changed from

==========
Check for already existing entry when adding to SiteProcessMap.

The SiteProcessMap::RegisterProcess can overwrite existing entries
in the map, which can lead to incorrect process being mapped to
a site in process-per-site mode. This CL checks for existence and
avoids the overwrite.

This CL is a reland of https://codereview.chromium.org/2739193004/
after the flaky test was fixed in https://codereview.chromium.org/2754173003/

BUG=700514
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Check for already existing entry when adding to SiteProcessMap.

The SiteProcessMap::RegisterProcess can overwrite existing entries
in the map, which can lead to incorrect process being mapped to
a site in process-per-site mode. This CL checks for existence and
avoids the overwrite.

This CL is a reland of https://codereview.chromium.org/2739193004/
after the flaky test was fixed in https://codereview.chromium.org/2754173003/

BUG=700514
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2760733002
Cr-Commit-Position: refs/heads/master@{#457925}
Committed:
https://chromium.googlesource.com/chromium/src/+/d1aaa76016c981807fbe10c53c00...
==========

[commit-bot: I haz the power, 2017-03-18 02:15:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d1aaa76016c981807fbe10c53c00...