The login dialog was being opened with the main browser window as a parent in...

chrome/browser/sync/profile_sync_service.h

Index: chrome/browser/sync/profile_sync_service.h
===================================================================
--- chrome/browser/sync/profile_sync_service.h	(revision 29327)
+++ chrome/browser/sync/profile_sync_service.h	(working copy)
@@ -63,7 +63,8 @@
 // and the sync backend.
 class ProfileSyncService : public NotificationObserver,
                            public browser_sync::SyncFrontend,
-                           public browser_sync::UnrecoverableErrorHandler {
+                           public browser_sync::UnrecoverableErrorHandler,
+                           public SyncSetupWizard::WizardParentDelegate {
  public:
   typedef ProfileSyncServiceObserver Observer;
   typedef browser_sync::SyncBackendHost::Status Status;
@@ -100,7 +101,7 @@
   void Initialize();
 
   // Enables/disables sync for user.
-  virtual void EnableForUser();
+  virtual void EnableForUser(gfx::NativeWindow parent_window);

[tim (not reviewing), 2009/10/29 21:58:44]

can we call it setup_dialog_parent_window, and add a comment above like 
"Enables/disables sync for the user. This will cause a setup dialog to be shown,
and you may use |setup_dialog_parent_window| to parent this dialog from a window
of your choosing."

   virtual void DisableForUser();
 
   // Whether sync is enabled by user or not.
@@ -147,7 +148,10 @@
   bool WizardIsVisible() const {
     return wizard_.IsVisible();
   }
-  void ShowLoginDialog();
+  gfx::NativeWindow GetWizardParent() const {

[tim (not reviewing), 2009/10/29 21:58:44]

please add virtual

+    return wizard_parent_window_;
+  }
+  void ShowLoginDialog(gfx::NativeWindow parent_window);

[tim (not reviewing), 2009/10/29 21:58:44]

the name of the variable is fine here, but please add a comment explaining it.

 
   // Pretty-printed strings for a given StatusSummary.
   static std::wstring BuildSyncStatusSummaryText(
@@ -301,6 +305,7 @@
   bool is_auth_in_progress_;
 
   SyncSetupWizard wizard_;
+  gfx::NativeWindow wizard_parent_window_;
 
   // True if an unrecoverable error (e.g. violation of an assumed invariant)
   // occurred during syncer operation.  This value should be checked before