Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 276072: The login dialog was being opened with the main browser window as a parent in... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service.cc
===================================================================
--- chrome/browser/sync/profile_sync_service.cc (revision 29327)
+++ chrome/browser/sync/profile_sync_service.cc (working copy)
@@ -151,11 +151,12 @@
last_attempted_user_email_.clear();
}
-void ProfileSyncService::EnableForUser() {
+void ProfileSyncService::EnableForUser(gfx::NativeWindow parent_window) {
if (WizardIsVisible()) {
// TODO(timsteele): Focus wizard.
return;
}
+ wizard_parent_window_ = parent_window;
expecting_first_run_auth_needed_event_ = true;
StartUp();
@@ -266,10 +267,12 @@
FOR_EACH_OBSERVER(Observer, observers_, OnStateChanged());
}
-void ProfileSyncService::ShowLoginDialog() {
+void ProfileSyncService::ShowLoginDialog(gfx::NativeWindow parent_window) {
if (WizardIsVisible())
return;
+ wizard_parent_window_ = parent_window;
+
if (!auth_error_time_.is_null()) {
UMA_HISTOGRAM_LONG_TIMES("Sync.ReauthorizationTime",
base::TimeTicks::Now() - auth_error_time_);

Powered by Google App Engine
This is Rietveld 408576698