Issue 276065: Bookmark bubble tweaks...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276065: Bookmark bubble tweaks... (Closed)

Created:
11 years, 2 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Bookmark bubble tweaks TitleCase the other folder menu options. Use the helper that handles ellipsis. TEST=the other folder option is title case BUG=24912 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29309

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+10 lines, -3 lines	1 comment	Download
	M	chrome/browser/cocoa/bookmark_bubble_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 2 months ago (2009-10-16 19:08:59 UTC) #2

LGTM

http://codereview.chromium.org/276065/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/276065/diff/1/2#newcode3409
Line 3409: <message name="IDS_BOOMARK_BUBBLE_CHOOSER_ANOTHER_FOLDER" desc="In
Title Case: Text in the combobox allowing the user to choose another folder (by
bringing up th editor).">
"th editor" should be "the editor"

Maybe fix it on 3404 too, but maybe not, if that'll cause new translations to be
required.

Expand Messages | Collapse Messages