Unregister from the InstallationNotifier in the dealloc.

Unregister from the InstallationNotifier in the dealloc.

When the NativeAppsCollectionViewController's parent controller is dismissed,
|isMovingFromParentViewController| is false.
The consequence is that the NativeAppsCollectionViewController was not unregistering itself from the InstallationNotifier. This led to crashes.

TEST=On iPhone:
     1/ Open the Google Apps settings menu (Settings > Google Apps).
     2/ Click on "Install" on one of the app (at least one app must not
        be installed).
     3/ From that AppStore UI, actually start the installation of one
        of the app.
     4/ As the installation is happening, close the AppStore UI, and
        close the Google Apps menu by pressing the "FINISHED" button
        (*not* the back arrow).
     5/ Wait for the download to finish without switching to an other
        app.
     6/ Notice that Chrome crashes.

BUG=701541
Review-Url: https://codereview.chromium.org/2760643002
Cr-Commit-Position: refs/heads/master@{#457781}
Committed: https://chromium.googlesource.com/chromium/src/+/1c24c4cd11bfc1e75e7cb02b18d41d075d1fea67

[jif, 2017-03-17 15:23:48]

Description was changed from

==========
Unregister from the InstallationNotifier in the dealloc.

The code path unregistering from the InstallationNotifier was not always
ran.

TEST=On iPhone:
     1/ Open the Google Apps settings menu (Settings > Google Apps).
     2/ Click on "Install" on one of the app (at least one app must not
        be installed).
     3/ From that AppStore UI, actually start the installation of one
        of the app.
     4/ As the installation is happening, close the AppStore UI, and
        close the Google Apps menu by pressing the "FINISHED" button
        (*not* the back arrow).
     5/ Wait for the download to finish without switching to an other
        app.
     6/ Notice that Chrome crashes.

BUG=701541
==========

to

==========
Unregister from the InstallationNotifier in the dealloc.

When the NativeAppsCollectionViewController's parent controller is dismissed,
|isMovingFromParentViewController| is false.
The consequence is that the NativeAppsCollectionViewController was not
unregistering itself from the InstallationNotifier. This led to crashes.

TEST=On iPhone:
     1/ Open the Google Apps settings menu (Settings > Google Apps).
     2/ Click on "Install" on one of the app (at least one app must not
        be installed).
     3/ From that AppStore UI, actually start the installation of one
        of the app.
     4/ As the installation is happening, close the AppStore UI, and
        close the Google Apps menu by pressing the "FINISHED" button
        (*not* the back arrow).
     5/ Wait for the download to finish without switching to an other
        app.
     6/ Notice that Chrome crashes.

BUG=701541
==========

[jif, 2017-03-17 15:23:48]

jif@chromium.org changed reviewers:
+ lpromero@chromium.org

[jif, 2017-03-17 15:23:55]

ptal

[lpromero, 2017-03-17 15:47:42]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-03-17 15:47:43]

lgtm

[commit-bot: I haz the power, 2017-03-17 15:48:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 16:00:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489765662961700, "parent_rev":
"af67da8cd666a5157de7a9f18024b1ea6fc99f37", "commit_rev":
"1c24c4cd11bfc1e75e7cb02b18d41d075d1fea67"}

[commit-bot: I haz the power, 2017-03-17 16:01:26]

Description was changed from

==========
Unregister from the InstallationNotifier in the dealloc.

When the NativeAppsCollectionViewController's parent controller is dismissed,
|isMovingFromParentViewController| is false.
The consequence is that the NativeAppsCollectionViewController was not
unregistering itself from the InstallationNotifier. This led to crashes.

TEST=On iPhone:
     1/ Open the Google Apps settings menu (Settings > Google Apps).
     2/ Click on "Install" on one of the app (at least one app must not
        be installed).
     3/ From that AppStore UI, actually start the installation of one
        of the app.
     4/ As the installation is happening, close the AppStore UI, and
        close the Google Apps menu by pressing the "FINISHED" button
        (*not* the back arrow).
     5/ Wait for the download to finish without switching to an other
        app.
     6/ Notice that Chrome crashes.

BUG=701541
==========

to

==========
Unregister from the InstallationNotifier in the dealloc.

When the NativeAppsCollectionViewController's parent controller is dismissed,
|isMovingFromParentViewController| is false.
The consequence is that the NativeAppsCollectionViewController was not
unregistering itself from the InstallationNotifier. This led to crashes.

TEST=On iPhone:
     1/ Open the Google Apps settings menu (Settings > Google Apps).
     2/ Click on "Install" on one of the app (at least one app must not
        be installed).
     3/ From that AppStore UI, actually start the installation of one
        of the app.
     4/ As the installation is happening, close the AppStore UI, and
        close the Google Apps menu by pressing the "FINISHED" button
        (*not* the back arrow).
     5/ Wait for the download to finish without switching to an other
        app.
     6/ Notice that Chrome crashes.

BUG=701541

Review-Url: https://codereview.chromium.org/2760643002
Cr-Commit-Position: refs/heads/master@{#457781}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c24c4cd11bfc1e75e7cb02b18d4...
==========

[commit-bot: I haz the power, 2017-03-17 16:01:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c24c4cd11bfc1e75e7cb02b18d4...