Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 276063003: Remove a call to initialize the TemplateURLService factory in this test. (Closed)

Created:
6 years, 7 months ago by erikwright (departed)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove a call to initialize the TemplateURLService factory in this test. This is already initialized by CocoaProfileTest. BUG=365762 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269713

Patch Set 1 #

Patch Set 2 : Some more adjustments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/search_engines/edit_search_engine_controller.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
erikwright (departed)
PTAL. This led to the following UAF: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/760/steps/unit_tests/logs/stdio The recent change that exposed this is ...
6 years, 7 months ago (2014-05-10 01:19:46 UTC) #1
erikwright (departed)
The CQ bit was checked by erikwright@chromium.org
6 years, 7 months ago (2014-05-10 01:30:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/276063003/1
6 years, 7 months ago (2014-05-10 01:35:14 UTC) #3
robertshield
lgtm
6 years, 7 months ago (2014-05-10 01:40:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 04:54:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 04:57:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66996)
6 years, 7 months ago (2014-05-10 04:57:48 UTC) #7
erikwright (departed)
The CQ bit was checked by erikwright@chromium.org
6 years, 7 months ago (2014-05-10 11:00:24 UTC) #8
erikwright (departed)
The CQ bit was unchecked by erikwright@chromium.org
6 years, 7 months ago (2014-05-10 11:01:09 UTC) #9
erikwright (departed)
The CQ bit was checked by erikwright@chromium.org
6 years, 7 months ago (2014-05-11 16:15:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/276063003/40001
6 years, 7 months ago (2014-05-11 16:15:48 UTC) #11
commit-bot: I haz the power
Change committed as 269713
6 years, 7 months ago (2014-05-11 17:26:59 UTC) #12
Alexei Svitkine (slow)
6 years, 7 months ago (2014-05-12 15:12:19 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698