chrome/browser/ui/cocoa/cocoa_profile_test.mm - Issue 276063003: Remove a call to initialize the TemplateURLService factory in this test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/cocoa_profile_test.mm

Issue 276063003: Remove a call to initialize the TemplateURLService factory in this test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Some more adjustments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm ('k') | chrome/browser/ui/search_engines/edit_search_engine_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/cocoa_profile_test.mm

diff --git a/chrome/browser/ui/cocoa/cocoa_profile_test.mm b/chrome/browser/ui/cocoa/cocoa_profile_test.mm

index bc634ca1f7b09030d08ce2c2446f77b84e6b4445..99c38b78a09e2c38bb4d3cafffbf4bd18c6f32f0 100644

--- a/chrome/browser/ui/cocoa/cocoa_profile_test.mm

+++ b/chrome/browser/ui/cocoa/cocoa_profile_test.mm

@@ -49,10 +49,6 @@ void CocoaProfileTest::SetUp() {

profile_ = profile_manager_.CreateTestingProfile("default");

ASSERT_TRUE(profile_);

- profile_->CreateBookmarkModel(true);

- test::WaitForBookmarkModelToLoad(

- BookmarkModelFactory::GetForProfile(profile_));

// TODO(shess): These are needed in case someone creates a browser

// window off of browser_. pkasting indicates that other

// platforms use a stub |BrowserWindow| and thus don't need to do

@@ -63,6 +59,10 @@ void CocoaProfileTest::SetUp() {

AutocompleteClassifierFactory::GetInstance()->SetTestingFactoryAndUse(

profile_, &AutocompleteClassifierFactory::BuildInstanceFor);

+ profile_->CreateBookmarkModel(true);

+ test::WaitForBookmarkModelToLoad(

+ BookmarkModelFactory::GetForProfile(profile_));

browser_.reset(CreateBrowser());

ASSERT_TRUE(browser_.get());

}