Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2760603002: Revert of MIPS[64]: Fix unaligned arguments storage in Wasm-to-interpreter entry (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
CC:
v8-mips-ports_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS[64]: Fix unaligned arguments storage in Wasm-to-interpreter entry (patchset #3 id:40001 of https://codereview.chromium.org/2705293011/ ) Reason for revert: Did not fix the issue. Original issue's description: > MIPS[64]: Fix unaligned arguments storage in Wasm-to-interpreter entry > > In Wasm-to-interpeter entry creation, arguments for the interpreter > are stored in an argument buffer. Depending on the order of the > arguments some arguments may be misaligned and this causes crashes > on those architectures that do not support unaligned memory access. > > TEST=cctest/test-wasm-interpreter-entry/TestArgumentPassing_AllTypes > BUG= > > Review-Url: https://codereview.chromium.org/2705293011 > Cr-Commit-Position: refs/heads/master@{#43476} > Committed: https://chromium.googlesource.com/v8/v8/+/84ff6e4c1997b63c01e95504c31ee6c5504430d5 TBR=titzer@chromium.org,ivica.bogosavljevic@imgtec.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2760603002 Cr-Commit-Position: refs/heads/master@{#43893} Committed: https://chromium.googlesource.com/v8/v8/+/29877f5ae0b486c8df275fd819d9505a161e320a

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M src/compiler/wasm-compiler.cc View 1 3 chunks +3 lines, -9 lines 0 comments Download
M src/utils.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/wasm/wasm-debug.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
Clemens Hammacher
Created Revert of MIPS[64]: Fix unaligned arguments storage in Wasm-to-interpreter entry
3 years, 9 months ago (2017-03-17 10:29:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760603002/100001
3 years, 9 months ago (2017-03-17 11:26:13 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 12:07:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/29877f5ae0b486c8df275fd819d9505a161...

Powered by Google App Engine
This is Rietveld 408576698