DevTools: Don't give up autocomplete after a fancy character in a string

DevTools: Don't give up autocomplete after a fancy character in a string

BUG=469473
Review-Url: https://codereview.chromium.org/2760583002
Cr-Commit-Position: refs/heads/master@{#458892}
Committed: https://chromium.googlesource.com/chromium/src/+/22c3c16558a8be6b881b05e2836feeb5ae92fcf0

[einbinder, 2017-03-17 09:52:23]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2017-03-17 09:52:23]

ptal

[dgozman, 2017-03-17 20:58:51]

lgtm

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html
(right):

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html:108:
() => testCompletions('complicatedObject["foo-bar', ['"foo-bar"]']),
Let's test example for the bug: "foo-".

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
(right):

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js:246:
return new Common.TextRange(lineNumber, token.startColumn, lineNumber,
columnNumber);
Should we just return null and use default?

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js (right):

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js:77: * @param
{number} column
columnNumber

[einbinder, 2017-03-20 17:50:47]

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html
(right):

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html:108:
() => testCompletions('complicatedObject["foo-bar', ['"foo-bar"]']),
On 2017/03/17 at 20:58:50, dgozman wrote:
> Let's test example for the bug: "foo-".

Done.

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
(right):

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js:246:
return new Common.TextRange(lineNumber, token.startColumn, lineNumber,
columnNumber);
On 2017/03/17 at 20:58:50, dgozman wrote:
> Should we just return null and use default?

Returning null here would disable autocomplete. The default substituteRange uses
isWordChar.

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js (right):

https://codereview.chromium.org/2760583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js:77: * @param
{number} column
On 2017/03/17 at 20:58:50, dgozman wrote:
> columnNumber

Done.

[einbinder, 2017-03-20 18:43:59]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-03-20 18:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2760583002/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-03-20 18:44:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:21:25]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2017-03-20 21:42:37]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:43:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 21:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:51:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[einbinder, 2017-03-21 23:36:00]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-03-21 23:36:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2760583002/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2017-03-21 23:36:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 01:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:38:30]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[einbinder, 2017-03-22 01:44:19]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:45:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 03:47:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:47:09]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[einbinder, 2017-03-22 22:03:44]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:04:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 22:12:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490220224458040,
"parent_rev": "6b033f1a96a84d279e687dc86054d4491e33d64a", "commit_rev":
"22c3c16558a8be6b881b05e2836feeb5ae92fcf0"}

[commit-bot: I haz the power, 2017-03-22 22:13:12]

Description was changed from

==========
DevTools: Don't give up autocomplete after a fancy character in a string

BUG=469473
==========

to

==========
DevTools: Don't give up autocomplete after a fancy character in a string

BUG=469473

Review-Url: https://codereview.chromium.org/2760583002
Cr-Commit-Position: refs/heads/master@{#458892}
Committed:
https://chromium.googlesource.com/chromium/src/+/22c3c16558a8be6b881b05e2836f...
==========

[commit-bot: I haz the power, 2017-03-22 22:13:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/22c3c16558a8be6b881b05e2836f...