Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2760533004: CANCELLED Non-laid-out node should not be considered as user-select:contain (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by Xiaocheng
Modified:
4 months ago
Reviewers:
tkent, yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CANCELLED Non-laid-out node should not be considered as user-select:contain This patch makes the current fake implementation of isUserSelectContain() slightly saner by returning false for non-laid-out nodes. This is also a preparation for removing layout update calls after applying editing commands: https://codereview.chromium.org/2729313002 BUG=702756 Test=VisibleUnitsTest.canonicalizeSelectOutOfFlatTree

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +2 lines, -0 lines 4 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +10 lines, -0 lines 4 comments Download
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 21 (12 generated)
Xiaocheng
PTAL.
4 months, 1 week ago (2017-03-20 22:16:42 UTC) #11
Xiaocheng
+tkent, yoichio
4 months, 1 week ago (2017-03-21 03:49:24 UTC) #13
yoichio
https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right): https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp#newcode302 third_party/WebKit/Source/core/editing/EditingUtilities.cpp:302: return false; We want |isUserSelectContain| independent from layout. Could ...
4 months, 1 week ago (2017-03-21 06:48:44 UTC) #14
yosin_UTC9
It seems we need to improve PositionInFlatTree ctor about checking validity of anchor node. https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp ...
4 months, 1 week ago (2017-03-21 08:48:51 UTC) #15
Xiaocheng
https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right): https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp#newcode302 third_party/WebKit/Source/core/editing/EditingUtilities.cpp:302: return false; On 2017/03/21 at 08:48:51, yosin_UTC9 wrote: > ...
4 months, 1 week ago (2017-03-21 20:27:48 UTC) #16
yosin_UTC9
https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right): https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp#newcode302 third_party/WebKit/Source/core/editing/EditingUtilities.cpp:302: return false; On 2017/03/21 at 20:27:48, Xiaocheng wrote: > ...
4 months, 1 week ago (2017-03-22 03:19:28 UTC) #17
Xiaocheng
On 2017/03/22 at 03:19:28, yosin wrote: > https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp > File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right): > > https://codereview.chromium.org/2760533004/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.cpp#newcode302 ...
4 months, 1 week ago (2017-03-22 03:47:40 UTC) #18
yosin_UTC9
On 2017/03/22 at 03:47:40, xiaochengh wrote: > On 2017/03/22 at 03:19:28, yosin wrote: > > ...
4 months, 1 week ago (2017-03-22 04:19:06 UTC) #19
Xiaocheng
4 months ago (2017-03-22 22:35:14 UTC) #21
I can't come up with a clean and simple patch that fixes this issue.

Hence closing it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973