Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2760463003: Reset Default Font on exit from PlatformFontLinuxTest. (Closed)

Created:
3 years, 9 months ago by Peter Mayo
Modified:
3 years, 9 months ago
Reviewers:
msw, Daniel Erat
CC:
chromium-reviews, derat+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset Default font on exit from PlatformFontLinuxTest. Without this we have an order dependency on other unit tests in gfx_unittests in the same process. BUG=702360 Review-Url: https://codereview.chromium.org/2760463003 Cr-Commit-Position: refs/heads/master@{#457625} Committed: https://chromium.googlesource.com/chromium/src/+/ce6b684e85eb02e3ff92e9b5e84fe2cfd1908f8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/gfx/platform_font_linux_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Peter Mayo
This happened to get in my way today, spent too long finding a small solution. ...
3 years, 9 months ago (2017-03-16 23:02:09 UTC) #2
Daniel Erat
sure, lgtm. thanks!
3 years, 9 months ago (2017-03-16 23:17:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760463003/1
3 years, 9 months ago (2017-03-16 23:27:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/387703)
3 years, 9 months ago (2017-03-16 23:40:48 UTC) #7
Peter Mayo
Need an OWNERS LGTM too.
3 years, 9 months ago (2017-03-16 23:47:04 UTC) #9
msw
lgtm
3 years, 9 months ago (2017-03-17 00:14:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760463003/1
3 years, 9 months ago (2017-03-17 00:19:31 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 00:45:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce6b684e85eb02e3ff92e9b5e84f...

Powered by Google App Engine
This is Rietveld 408576698