Remove enable_media_router.

Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG=461815, 704958
TBR=cpu

Review-Url: https://codereview.chromium.org/2760403003
Cr-Commit-Position: refs/heads/master@{#466043}
Committed: https://chromium.googlesource.com/chromium/src/+/678822e951c8943cc2b80657eeaec130d82b7385

[Nico, 2017-03-21 19:50:20]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 19:51:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-21 19:58:34]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 19:59:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-21 19:59:32]

thakis@chromium.org changed reviewers:
+ imcheng@chromium.org

[Nico, 2017-03-21 19:59:33]

enable_media_router looks like something that was used during bring-up and is
always on now but wasn't removed yet.

https://codereview.chromium.org/2760403003/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2760403003/diff/1/BUILD.gn#oldcode211
BUILD.gn:211: deps += [ "//chrome/browser/media/router" ]
//chrome already depends on this, no longer needed

[commit-bot: I haz the power, 2017-03-21 20:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:02:42]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nico, 2017-03-21 20:08:35]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 20:09:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:14:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-03-21 20:16:18]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 20:16:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:22:30]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2017-03-21 20:24:27]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 20:25:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mark a. foltz, 2017-03-21 20:48:24]

mfoltz@chromium.org changed reviewers:
+ mfoltz@chromium.org, slan@chromium.org

[mark a. foltz, 2017-03-21 20:48:25]

enable_media_router is disabled for chromecast builds and they intend to keep it
that way AFAIK.  Was just discussing this with slan@.

[Nico, 2017-03-21 20:50:49]

But chromecast doesn't use any of chrome/, right?

On Tue, Mar 21, 2017 at 4:48 PM, <mfoltz@chromium.org> wrote:

> enable_media_router is disabled for chromecast builds and they intend to
> keep it
> that way AFAIK. Was just discussing this with slan@.
>
> https://codereview.chromium.org/2760403003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mark a. foltz, 2017-03-21 21:06:33]

On 2017/03/21 at 20:50:49, thakis wrote:
> But chromecast doesn't use any of chrome/, right?

Not sure - I see a is_chromecast reference in chrome/browser/ui/BUILD.gn. 
slan@?

> On Tue, Mar 21, 2017 at 4:48 PM, <mfoltz@chromium.org> wrote:
> 
> > enable_media_router is disabled for chromecast builds and they intend to
> > keep it
> > that way AFAIK. Was just discussing this with slan@.
> >
> > https://codereview.chromium.org/2760403003/

[mark a. foltz, 2017-03-21 21:11:16]

LGTM as far as I'm concerned :)

[slan, 2017-03-21 21:19:33]

On 2017/03/21 21:06:33, mark a. foltz wrote:
> On 2017/03/21 at 20:50:49, thakis wrote:
> > But chromecast doesn't use any of chrome/, right?
> 
> Not sure - I see a is_chromecast reference in chrome/browser/ui/BUILD.gn. 
> slan@?
> 
> > On Tue, Mar 21, 2017 at 4:48 PM, <mailto:mfoltz@chromium.org> wrote:
> > 
> > > enable_media_router is disabled for chromecast builds and they intend to
> > > keep it
> > > that way AFAIK. Was just discussing this with slan@.
> > >
> > > https://codereview.chromium.org/2760403003/

+antz@ to field this question fully. Anthony, do you remember why we disabled
all these features in //chrome? Ideally, this should not impact the binary at
all....

//chromecast should NOT reference anything in //chrome. We do not have any
direct GN deps except VERSION:
https://cs.chromium.org/search/?q=//chrome%5Cb+file:chromecast&type=cs, but that
doesn't mean that one of the intermediate GN targets isn't violating that
assumption:
https://cs.chromium.org/search/?q=//chrome%5Cb+file:%5C.gn+-file:chrome/*&typ...

...there are many possible paths from cast_shell -> {intermediate_target} ->
//chrome/*

[slan, 2017-03-21 21:19:51]

slan@chromium.org changed reviewers:
+ antz@chromium.org

[Nico, 2017-03-21 21:30:36]

Looking forward to antz's reply, but in reply to

> ...there are many possible paths from cast_shell -> {intermediate_target}
-> chrome

You could do something like https://codereview.chromium.org/2769483002/ for
is_chromecast to make sure chrome/ isn't used there accidentally.

On Tue, Mar 21, 2017 at 5:19 PM, <slan@chromium.org> wrote:

> https://codereview.chromium.org/2760403003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-03-21 21:33:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 21:33:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2017-03-21 21:38:54]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 21:39:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 22:58:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 22:58:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Nico, 2017-03-21 23:14:17]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 23:14:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 23:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:20:52]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Nico, 2017-03-21 23:28:44]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 23:29:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 01:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:16:44]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[Nico, 2017-03-22 01:22:48]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 01:23:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 01:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:35:00]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-03-22 15:42:37]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 15:43:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 15:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 15:49:15]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nico, 2017-03-22 19:42:38]

antz: ping. This CL is fairly annoying to rebase since it touches
chrome/test/BUILD.gn.

On Tue, Mar 21, 2017 at 5:30 PM, Nico Weber <thakis@chromium.org> wrote:

> Looking forward to antz's reply, but in reply to
>
> > ...there are many possible paths from cast_shell ->
> {intermediate_target} -> chrome
>
> You could do something like https://codereview.chromium.org/2769483002/
> for is_chromecast to make sure chrome/ isn't used there accidentally.
>
> On Tue, Mar 21, 2017 at 5:19 PM, <slan@chromium.org> wrote:
>
>> https://codereview.chromium.org/2760403003/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2017-03-23 18:02:02]

Looks like antz is away. slan, can you review this for cast?

On Wed, Mar 22, 2017 at 3:42 PM, Nico Weber <thakis@chromium.org> wrote:

> antz: ping. This CL is fairly annoying to rebase since it touches
> chrome/test/BUILD.gn.
>
> On Tue, Mar 21, 2017 at 5:30 PM, Nico Weber <thakis@chromium.org> wrote:
>
>> Looking forward to antz's reply, but in reply to
>>
>> > ...there are many possible paths from cast_shell ->
>> {intermediate_target} -> chrome
>>
>> You could do something like https://codereview.chromium.org/2769483002/
>> for is_chromecast to make sure chrome/ isn't used there accidentally.
>>
>> On Tue, Mar 21, 2017 at 5:19 PM, <slan@chromium.org> wrote:
>>
>>> https://codereview.chromium.org/2760403003/
>>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[slan, 2017-03-23 18:12:16]

On 2017/03/23 18:02:02, Nico wrote:
> Looks like antz is away. slan, can you review this for cast?
> 
> On Wed, Mar 22, 2017 at 3:42 PM, Nico Weber <mailto:thakis@chromium.org>
wrote:
> 
> > antz: ping. This CL is fairly annoying to rebase since it touches
> > chrome/test/BUILD.gn.
> >
> > On Tue, Mar 21, 2017 at 5:30 PM, Nico Weber <mailto:thakis@chromium.org>
wrote:
> >
> >> Looking forward to antz's reply, but in reply to
> >>
> >> > ...there are many possible paths from cast_shell ->
> >> {intermediate_target} -> chrome
> >>
> >> You could do something like https://codereview.chromium.org/2769483002/
> >> for is_chromecast to make sure chrome/ isn't used there accidentally.
> >>
> >> On Tue, Mar 21, 2017 at 5:19 PM, <mailto:slan@chromium.org> wrote:
> >>
> >>> https://codereview.chromium.org/2760403003/
> >>>
> >>
> >>
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Without doing a full probe of the implicit dependencies, I can't know for sure
if this will affect us, but lgtm for now. If we see a binary size jump we can
try to examine why. 

Is there any mechanism beyond developer goodwill to keep features like
media_router contained to chrome/ and extensions/ ?

Thanks for the review, all. Sorry for the hold up.

[Nico, 2017-03-23 18:21:30]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-23 18:21:30]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2760403003/#ps120001
(title: ".")

[commit-bot: I haz the power, 2017-03-23 18:22:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:25:56]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mark a. foltz, 2017-03-23 20:19:08]

On 2017/03/23 at 18:12:16, slan wrote:
> On 2017/03/23 18:02:02, Nico wrote:
> > Looks like antz is away. slan, can you review this for cast?
> > 
> > On Wed, Mar 22, 2017 at 3:42 PM, Nico Weber <mailto:thakis@chromium.org>
wrote:
> > 
> > > antz: ping. This CL is fairly annoying to rebase since it touches
> > > chrome/test/BUILD.gn.
> > >
> > > On Tue, Mar 21, 2017 at 5:30 PM, Nico Weber <mailto:thakis@chromium.org>
wrote:
> > >
> > >> Looking forward to antz's reply, but in reply to
> > >>
> > >> > ...there are many possible paths from cast_shell ->
> > >> {intermediate_target} -> chrome
> > >>
> > >> You could do something like https://codereview.chromium.org/2769483002/
> > >> for is_chromecast to make sure chrome/ isn't used there accidentally.
> > >>
> > >> On Tue, Mar 21, 2017 at 5:19 PM, <mailto:slan@chromium.org> wrote:
> > >>
> > >>> https://codereview.chromium.org/2760403003/
> > >>>
> > >>
> > >>
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> Without doing a full probe of the implicit dependencies, I can't know for sure
if this will affect us, but lgtm for now. If we see a binary size jump we can
try to examine why. 
> 
> Is there any mechanism beyond developer goodwill to keep features like
media_router contained to chrome/ and extensions/ ?
> 
> Thanks for the review, all. Sorry for the hold up.

1. See the patch linked in the previous comment:  This will cause gn to assert
if it loads a file in chrome/ with is_chromecast = true.

2. There is already a DEPS file in content/ to prevent #include dependencies on
chrome/.  This prevents media_router specific code from leaking into content/. 
See https://cs.chromium.org/chromium/src/content/DEPS

3. You could add an additional DEPS file in the Chromecast build tree that would
fail on presubmit if chrome/ includes were encountered.

[mark a. foltz, 2017-03-30 21:39:47]

Sorry to nag, but do you still plan on committing this?  We have a different bug
that we could close out by landing this.  crbug.com/704617

[Nico, 2017-03-30 21:49:45]

Yes, I want to land this. It needs some work to rebase though, and I won't
have time before Tuesday. Of you're in a rush, feel free to take over.

On Mar 30, 2017 5:39 PM, <mfoltz@chromium.org> wrote:

> Sorry to nag, but do you still plan on committing this? We have a
> different bug
> that we could close out by landing this. crbug.com/704617
>
>
> https://codereview.chromium.org/2760403003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2017-04-20 14:31:16]

Description was changed from

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

It's also used in one place in extensions/. That's not used on iOS but
might be used on cast, so this might be a small behavior change
there.

BUG=461815
==========

to

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

BUG=461815
==========

[Nico, 2017-04-20 14:33:45]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 14:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 14:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 14:42:55]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Nico, 2017-04-20 15:05:38]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 15:05:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-04-20 15:06:48]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 15:07:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-04-20 15:07:25]

https://codereview.chromium.org/2771413003/ finally landed, and I rebased this
across it. I'll try to land this today.

[Nico, 2017-04-20 15:12:32]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 15:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-04-20 15:16:19]

Description was changed from

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

BUG=461815
==========

to

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG=461815
==========

[Nico, 2017-04-20 15:20:12]

Description was changed from

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG=461815
==========

to

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG=461815,704958
==========

[Nico, 2017-04-20 15:32:09]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-04-20 15:32:15]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-04-20 15:32:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
slan@chromium.org
Link to the patchset: https://codereview.chromium.org/2760403003/#ps220001
(title: ".")

[commit-bot: I haz the power, 2017-04-20 15:32:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 15:42:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 15:42:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-04-20 15:45:03]

Description was changed from

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG=461815,704958
==========

to

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG=461815,704958
TBR=cpu
==========

[Nico, 2017-04-20 15:45:40]

thakis@chromium.org changed reviewers:
+ cpu@chromium.org

[Nico, 2017-04-20 15:45:41]

TBR CPU for whitelist.cc

[Nico, 2017-04-20 15:45:52]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-04-20 15:46:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 17:20:37]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1492703152160340,
"parent_rev": "7cc769d230580677418d35623a89fc6ae60c7167", "commit_rev":
"678822e951c8943cc2b80657eeaec130d82b7385"}

[commit-bot: I haz the power, 2017-04-20 17:20:50]

Description was changed from

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG=461815,704958
TBR=cpu
==========

to

==========
Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG=461815,704958
TBR=cpu

Review-Url: https://codereview.chromium.org/2760403003
Cr-Commit-Position: refs/heads/master@{#466043}
Committed:
https://chromium.googlesource.com/chromium/src/+/678822e951c8943cc2b80657eeae...
==========

[commit-bot: I haz the power, 2017-04-20 17:20:52]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/678822e951c8943cc2b80657eeae...