Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Issue 2760393004: MD Settings: make input with error msg scale spacing with font-size. (Closed)

Created:
3 years, 9 months ago by scottchen
Modified:
3 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: make input with error msg scale spacing with font-size. BUG=703528 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2760393004 Cr-Commit-Position: refs/heads/master@{#458897} Committed: https://chromium.googlesource.com/chromium/src/+/29049fd00eb628cff76d2eda785e4e03e80be962

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html View 1 chunk +11 lines, -1 line 2 comments Download

Messages

Total messages: 12 (5 generated)
scottchen
3 years, 9 months ago (2017-03-21 21:23:12 UTC) #3
scottchen
3 years, 9 months ago (2017-03-21 21:23:14 UTC) #4
dpapad
https://codereview.chromium.org/2760393004/diff/1/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html File chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html (right): https://codereview.chromium.org/2760393004/diff/1/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html#newcode12 chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html:12: --paper-input-container: { Could you attach before/after screenshots?
3 years, 9 months ago (2017-03-21 22:33:34 UTC) #5
scottchen
https://codereview.chromium.org/2760393004/diff/1/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html File chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html (right): https://codereview.chromium.org/2760393004/diff/1/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html#newcode12 chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html:12: --paper-input-container: { On 2017/03/21 22:33:34, dpapad wrote: > Could ...
3 years, 9 months ago (2017-03-22 18:01:39 UTC) #6
dpapad
lgtm
3 years, 9 months ago (2017-03-22 20:42:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760393004/1
3 years, 9 months ago (2017-03-22 21:12:26 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 22:22:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29049fd00eb628cff76d2eda785e...

Powered by Google App Engine
This is Rietveld 408576698