[Password Manager] Don't send |UsernameCorrection| in |PasswordFormFillData| to the renderer

[Password Manager] Don't send |UsernameCorrection| in |PasswordFormFillData| to the renderer

At this time, other possible usernames are disabled in production (i.e. Chrome don't show dropdown list to select another username). Sending usernames to render is useless for the user. Let's not send them in |PasswordFormFillData| to increase security/privacy.

BUG=188908
Review-Url: https://codereview.chromium.org/2760353003
Cr-Commit-Position: refs/heads/master@{#458750}
Committed: https://chromium.googlesource.com/chromium/src/+/c85bdf433f16428084e93da3b24bf5e86e0f117e

[kolos1, 2017-03-22 12:28:10]

Description was changed from

==========
[Password Manager] Don't send |UsernameCorrection| in |PasswordFormFillData| to
the renderer

At this time, other possible usernames are disabled in production. Let's not
send them in |PasswordFormFillData| to increase security/privacy.

BUG=628104
==========

to

==========
[Password Manager] Don't send |UsernameCorrection| in |PasswordFormFillData| to
the renderer

At this time, other possible usernames are disabled in production (i.e. Chrome
don't show dropdown list to select another username). Sending usernames to
render is useless for the user. Let's not send them in |PasswordFormFillData| to
increase security/privacy.

BUG=188908
==========

[kolos1, 2017-03-22 12:42:49]

Patchset #1 (id:1) has been deleted

[kolos1, 2017-03-22 12:47:31]

kolos@chromium.org changed reviewers:
+ dvadym@chromium.org

[dvadym, 2017-03-22 13:13:53]

Thanks for removing sending OtherPossibleUsername.
LGTM % nit

https://codereview.chromium.org/2760353003/diff/60001/components/autofill/cor...
File components/autofill/core/common/password_form_fill_data.cc (right):

https://codereview.chromium.org/2760353003/diff/60001/components/autofill/cor...
components/autofill/core/common/password_form_fill_data.cc:87: //
TODO(crbug/188908). Remove |other_possible_usernames| or launch.
It's not good to leave commented code. It's better to remove these lines at all
and move TODO as comment of |other_possible_usernames| field in class
PasswordFormFillData.

[kolos1, 2017-03-22 13:30:46]

kolos@chromium.org changed reviewers:
+ mkwst@chromium.org

[kolos1, 2017-03-22 13:30:47]

mkwst@: Please review mojo.

Regards,
Maxim

[Mike West, 2017-03-22 13:46:39]

Removing code LGTM yay \o/!

But please remove the commented-out code instead of just commenting it out.

https://codereview.chromium.org/2760353003/diff/60001/components/autofill/cor...
File components/autofill/core/common/password_form_fill_data.cc (right):

https://codereview.chromium.org/2760353003/diff/60001/components/autofill/cor...
components/autofill/core/common/password_form_fill_data.cc:87: //
TODO(crbug/188908). Remove |other_possible_usernames| or launch.
On 2017/03/22 at 13:13:53, dvadym wrote:
> It's not good to leave commented code. It's better to remove these lines at
all and move TODO as comment of |other_possible_usernames| field in class
PasswordFormFillData.

I agree!

[kolos1, 2017-03-22 14:01:10]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[kolos1, 2017-03-22 14:01:15]

https://codereview.chromium.org/2760353003/diff/60001/components/autofill/cor...
File components/autofill/core/common/password_form_fill_data.cc (right):

https://codereview.chromium.org/2760353003/diff/60001/components/autofill/cor...
components/autofill/core/common/password_form_fill_data.cc:87: //
TODO(crbug/188908). Remove |other_possible_usernames| or launch.
On 2017/03/22 13:46:39, Mike West wrote:
> On 2017/03/22 at 13:13:53, dvadym wrote:
> > It's not good to leave commented code. It's better to remove these lines at
> all and move TODO as comment of |other_possible_usernames| field in class
> PasswordFormFillData.
> 
> I agree!

Done.

[commit-bot: I haz the power, 2017-03-22 14:01:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kolos1, 2017-03-22 14:14:45]

The CQ bit was unchecked by kolos@chromium.org

[kolos1, 2017-03-22 14:14:46]

The CQ bit was checked by kolos@chromium.org

[kolos1, 2017-03-22 14:14:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dvadym@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2760353003/#ps80001
(title: "Removed commented code. Added bug number to the UsernamesCollection
declaration")

[commit-bot: I haz the power, 2017-03-22 14:15:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 14:57:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490192086401460,
"parent_rev": "ba607278f124cd99822dda9cde8dfdaecef830a0", "commit_rev":
"c85bdf433f16428084e93da3b24bf5e86e0f117e"}

[commit-bot: I haz the power, 2017-03-22 14:58:24]

Description was changed from

==========
[Password Manager] Don't send |UsernameCorrection| in |PasswordFormFillData| to
the renderer

At this time, other possible usernames are disabled in production (i.e. Chrome
don't show dropdown list to select another username). Sending usernames to
render is useless for the user. Let's not send them in |PasswordFormFillData| to
increase security/privacy.

BUG=188908
==========

to

==========
[Password Manager] Don't send |UsernameCorrection| in |PasswordFormFillData| to
the renderer

At this time, other possible usernames are disabled in production (i.e. Chrome
don't show dropdown list to select another username). Sending usernames to
render is useless for the user. Let's not send them in |PasswordFormFillData| to
increase security/privacy.

BUG=188908

Review-Url: https://codereview.chromium.org/2760353003
Cr-Commit-Position: refs/heads/master@{#458750}
Committed:
https://chromium.googlesource.com/chromium/src/+/c85bdf433f16428084e93da3b24b...
==========

[commit-bot: I haz the power, 2017-03-22 14:58:25]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c85bdf433f16428084e93da3b24b...