Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2760313002:
[tests] PrettyPrint for TypedArrays (Closed)
|
Created:
3 years, 9 months ago by Choongwoo Han Modified:
3 years, 9 months ago Reviewers:
Camillo Bruni CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[mjsunit] PrettyPrint for TypedArrays
Review-Url: https://codereview.chromium.org/2760313002
Cr-Commit-Position: refs/heads/master@{#44017}
Committed: https://chromium.googlesource.com/v8/v8/+/008a09619b7f4d42a5732ec5801ad86bbd1b56b8
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
Description was changed from ========== [tests] PrettyPrint for TypedArrays BUG=none ========== to ========== [tests] PrettyPrint for TypedArrays BUG=none ==========
cwhan.tunz@gmail.com changed reviewers: + jochen@chromium.org
hey, can you please provide some more context for why this is needed? I saw you recently submitted a bunch of patches for typed arrays (thanks!). Maybe one of the reviewers on those patches has more context?
On 2017/03/21 13:11:32, jochen wrote: > hey, can you please provide some more context for why this is needed? > > I saw you recently submitted a bunch of patches for typed arrays (thanks!). > Maybe one of the reviewers on those patches has more context? Sorry for missing context. I need detailed information when some testcases fail. For example, I want `oh, we failed: Failure: expected <Uint8Array())> found <Uint8Array()>` instead, `oh, we failed: Failure: expected <Uint8Array([1,2,3])> found <Uint8Array([3,2,1])>`
On 2017/03/21 13:16:40, Choongwoo Han wrote: > On 2017/03/21 13:11:32, jochen wrote: > > hey, can you please provide some more context for why this is needed? > > > > I saw you recently submitted a bunch of patches for typed arrays (thanks!). > > Maybe one of the reviewers on those patches has more context? > > Sorry for missing context. I need detailed information when some testcases fail. > > For example, I want > `oh, we failed: Failure: expected <Uint8Array())> found <Uint8Array()>` > instead, > `oh, we failed: Failure: expected <Uint8Array([1,2,3])> found > <Uint8Array([3,2,1])>` sorry, it's opposite. I want `oh, we failed: Failure: expected <Uint8Array([1,2,3])> found <Uint8Array([3,2,1])>` instead, `oh, we failed: Failure: expected <Uint8Array())> found <Uint8Array()>` Can I add any reviewer for this? since I cannot find owners of mjsunit, so I just added you.
right, anybody from the top-level OWNERS file can review this, so adding somebody with more context for this work would be great
cwhan.tunz@gmail.com changed reviewers: + cbruni@chromium.org - jochen@chromium.org
cbruni@ PTAL? currently, test failures on typed arrays are not much informative: `oh, we failed: Failure: expected <Uint8Array())> found <Uint8Array()>` so, this patch shows elements of typed arrays when a test case files: `oh, we failed: Failure: expected <Uint8Array([1,2,3])> found <Uint8Array([3,2,1])>`
Description was changed from ========== [tests] PrettyPrint for TypedArrays BUG=none ========== to ========== [tests] PrettyPrint for TypedArrays ==========
Description was changed from ========== [tests] PrettyPrint for TypedArrays ========== to ========== [mjsunit] PrettyPrint for TypedArrays ==========
lgtm
The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by cwhan.tunz@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490185451705830, "parent_rev":
"66a5600505d585d766408858d101ccdc6935c41a", "commit_rev":
"008a09619b7f4d42a5732ec5801ad86bbd1b56b8"}
Message was sent while issue was closed.
Description was changed from ========== [mjsunit] PrettyPrint for TypedArrays ========== to ========== [mjsunit] PrettyPrint for TypedArrays Review-Url: https://codereview.chromium.org/2760313002 Cr-Commit-Position: refs/heads/master@{#44017} Committed: https://chromium.googlesource.com/v8/v8/+/008a09619b7f4d42a5732ec5801ad86bbd1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/008a09619b7f4d42a5732ec5801ad86bbd1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
