Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2760273002: Dispose temporary Range in Selection::collapse (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Dispose temporary Range in Selection::collapse That is neither cached nor exposed to js. BUG=693975 Review-Url: https://codereview.chromium.org/2760273002 Cr-Commit-Position: refs/heads/master@{#458622} Committed: https://chromium.googlesource.com/chromium/src/+/9608ef8b7480c2d5d86afde8726c0bfbcfb47c7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yoichio
3 years, 9 months ago (2017-03-22 01:43:22 UTC) #7
yoichio
PTAL
3 years, 9 months ago (2017-03-22 03:57:42 UTC) #8
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-22 04:09:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760273002/1
3 years, 9 months ago (2017-03-22 04:09:46 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 04:15:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9608ef8b7480c2d5d86afde8726c...

Powered by Google App Engine
This is Rietveld 408576698