Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2760233004: Make all setNeedsReattachLayoutTree happen from updateStyle. (Closed)
Patch Set: Corrected DCHECK condition Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved. 5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
7 * (http://www.torchmobile.com/) 7 * (http://www.torchmobile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 951 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 if (needsAttach()) 962 if (needsAttach())
963 return; 963 return;
964 if (!inActiveDocument()) 964 if (!inActiveDocument())
965 return; 965 return;
966 966
967 AttachContext context; 967 AttachContext context;
968 context.performingReattach = true; 968 context.performingReattach = true;
969 969
970 detachLayoutTree(context); 970 detachLayoutTree(context);
971 markAncestorsWithChildNeedsStyleRecalc(); 971 markAncestorsWithChildNeedsStyleRecalc();
972 markAncestorsWithChildNeedsReattachLayoutTree();
973 } 972 }
974 973
975 inline bool Node::shouldCallRecalcStyle(StyleRecalcChange change) { 974 inline bool Node::shouldCallRecalcStyle(StyleRecalcChange change) {
976 return change >= IndependentInherit || needsStyleRecalc() || 975 return change >= IndependentInherit || needsStyleRecalc() ||
977 childNeedsStyleRecalc(); 976 childNeedsStyleRecalc();
978 } 977 }
979 978
980 inline bool isTreeScopeRoot(const Node* node) { 979 inline bool isTreeScopeRoot(const Node* node) {
981 return !node || node->isDocumentNode() || node->isShadowRoot(); 980 return !node || node->isDocumentNode() || node->isShadowRoot();
982 } 981 }
(...skipping 29 matching lines...) Expand all
1012 } // namespace blink 1011 } // namespace blink
1013 1012
1014 #ifndef NDEBUG 1013 #ifndef NDEBUG
1015 // Outside the WebCore namespace for ease of invocation from gdb. 1014 // Outside the WebCore namespace for ease of invocation from gdb.
1016 void showNode(const blink::Node*); 1015 void showNode(const blink::Node*);
1017 void showTree(const blink::Node*); 1016 void showTree(const blink::Node*);
1018 void showNodePath(const blink::Node*); 1017 void showNodePath(const blink::Node*);
1019 #endif 1018 #endif
1020 1019
1021 #endif // Node_h 1020 #endif // Node_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698