Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2760223002: Revert of Allow MojoAsyncResourceHandler::OnWillRead to complete asyncronously (Closed)

Created:
3 years, 9 months ago by yhirano
Modified:
3 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, loading-reviews_chromium.org, darin (slow to review), yhirano
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow MojoAsyncResourceHandler::OnWillRead to complete asyncronously (patchset #5 id:80001 of https://codereview.chromium.org/2738973002/ ) Reason for revert: This CL leads to a layout test crash. virtual/mojo-loading/http/tests/serviceworker/chromium/request-body-blob-crash.html Original issue's description: > when a Mojo buffer can't be allocated synchronously. > > The class still needs to create its own intermediary buffer > when the Mojo buffer is too small to meet the > MimeSniffingResourceHandler's needs, but once that's fixed, > the class can be made significantly simpler. > > BUG=687240 > > Review-Url: https://codereview.chromium.org/2738973002 > Cr-Commit-Position: refs/heads/master@{#458093} > Committed: https://chromium.googlesource.com/chromium/src/+/2ba831790eccdf8fa9178eef72b8479a12a2f8aa TBR=rdsmith@chromium.org,mmenke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687240, 703471 Review-Url: https://codereview.chromium.org/2760223002 Cr-Commit-Position: refs/heads/master@{#458297} Committed: https://chromium.googlesource.com/chromium/src/+/4fede0f13bb7bd62971e98b966548953b56059aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -240 lines) Patch
M content/browser/loader/mock_resource_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/mojo_async_resource_handler.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 11 chunks +64 lines, -72 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 9 chunks +57 lines, -159 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
yhirano
Created Revert of Allow MojoAsyncResourceHandler::OnWillRead to complete asyncronously
3 years, 9 months ago (2017-03-21 03:29:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760223002/1
3 years, 9 months ago (2017-03-21 03:30:54 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 03:39:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4fede0f13bb7bd62971e98b96654...

Powered by Google App Engine
This is Rietveld 408576698