Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2760143002: Update ios/web_view/shell UIDelegate implementation. (Closed)

Created:
3 years, 9 months ago by michaeldo
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org, sdefresne
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ios/web_view/shell UIDelegate implementation. Reconnect the UIDelegate for the ShellViewController in ios/web_view/shell and complete UIDelegate implementation by adding log statements in optional methods. BUG=none Review-Url: https://codereview.chromium.org/2760143002 Cr-Commit-Position: refs/heads/master@{#458272} Committed: https://chromium.googlesource.com/chromium/src/+/bc52333ce78f95a119bd13a0c3d821bb1d199f4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M ios/web_view/internal/cwv_web_view.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web_view/shell/shell_view_controller.m View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
michaeldo
3 years, 9 months ago (2017-03-20 22:37:37 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 9 months ago (2017-03-21 00:50:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760143002/1
3 years, 9 months ago (2017-03-21 01:34:33 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 01:46:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc52333ce78f95a119bd13a0c3d8...

Powered by Google App Engine
This is Rietveld 408576698