content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl - Issue 2760093002: Making callbacks in Android ChildProcessLauncher generic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl

Issue 2760093002: Making callbacks in Android ChildProcessLauncher generic. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/common/IChildProcessService.aidl ('k') | content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl

diff --git a/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl b/content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl

similarity index 91%

rename from content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

rename to content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl

index 4285e3d9b6aeba88bc7b83694e0deb6daa31bdac..c2ad7945dc42c10a5238e45077c9ca86a7158b0e 100644

--- a/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

+++ b/content/public/android/java/src/org/chromium/content/common/IContentChildProcessCallback.aidl

@@ -7,7 +7,7 @@ package org.chromium.content.common;

import org.chromium.content.common.SurfaceWrapper;

import android.view.Surface;

-interface IChildProcessCallback {

+interface IContentChildProcessCallback {

boliu 2017/03/20 22:39:16 Let's bikeshed the name.. this is now only about S

Jay Civelli 2017/03/20 22:41:57 Actually I was thinking about this when I sent it

boliu 2017/03/20 22:45:48 sgtm

void forwardSurfaceForSurfaceRequest(

in UnguessableToken requestToken, in Surface surface);