Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2760063003: Remove the -webkit-fullscreen-volume-* pseudos, they're dead code. (Closed)

Created:
3 years, 9 months ago by esprehn
Modified:
3 years, 9 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dshwang, dtseng+watch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, jchaffraix+rendering, je_julie, kinuko+watch, leviw+renderwatch, mlamouri+watch-blink_chromium.org, nektar+watch_chromium.org, nektarios, pdr+renderingwatchlist_chromium.org, rwlbuis, nessy, Srirama, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the -webkit-fullscreen-volume-* pseudos, they're dead code. This was added for an ancient version of the media controls back in 2012: https://chromium.googlesource.com/chromium/src/+/01b1110b198ad023fcdf22092e570b80b2a1020a That doesn't appear to exist anymore. Removing this reduces the number of cases where ::shadowPseudoId() dynamically returns a different value. BUG=701655 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2760063003 Cr-Commit-Position: refs/heads/master@{#458301} Committed: https://chromium.googlesource.com/chromium/src/+/cadf4232009c7877216ff5485244c263193ac4f5

Patch Set 1 #

Messages

Total messages: 20 (12 generated)
esprehn
3 years, 9 months ago (2017-03-20 22:43:25 UTC) #5
esprehn
3 years, 9 months ago (2017-03-20 22:47:29 UTC) #8
rune
lgtm
3 years, 9 months ago (2017-03-20 23:42:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760063003/1
3 years, 9 months ago (2017-03-21 00:04:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 9 months ago (2017-03-21 00:44:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760063003/1
3 years, 9 months ago (2017-03-21 02:29:04 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cadf4232009c7877216ff5485244c263193ac4f5
3 years, 9 months ago (2017-03-21 03:48:42 UTC) #19
mlamouri (slow - plz ping)
3 years, 9 months ago (2017-03-21 11:38:51 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698