Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: components/previews/core/previews_decider.h

Issue 2760063002: Add support to previews/ for Server LoFi and LitePages (Closed)
Patch Set: tbansal comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/core/previews_decider.h
diff --git a/components/previews/core/previews_decider.h b/components/previews/core/previews_decider.h
index f293c87c1ad0f621e85cf0756f6872cf0c2f6c60..643a4aeffbba954dd7ccde00c4df5ffe5562ddad 100644
--- a/components/previews/core/previews_decider.h
+++ b/components/previews/core/previews_decider.h
@@ -15,7 +15,10 @@ namespace previews {
class PreviewsDecider {
public:
- // Whether |request| is allowed to show a preview of |type|.
+ // Whether |request| is allowed to show a preview of |type|. Previews that do
+ // not supply a network quality in
+ // GetEffectiveConnectionTypeThresholdForPreviewsType() should check the
+ // network quality before calling ShouldAllowPreview.
virtual bool ShouldAllowPreview(const net::URLRequest& request,
PreviewsType type) const = 0;

Powered by Google App Engine
This is Rietveld 408576698