Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index cc4c904c2f965738ab447956756f06dcc9281668..788e3073003ecfce7e9c710d642734e314fce021 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -55390,43 +55390,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="Previews.EligibilityReason" enum="PreviewsEligibilityReason"> |
| <owner>ryansturm@chromium.org</owner> |
| <summary> |
| - Whether a particular preview was allowed to be shown or the reason the |
| - preview could not be shown to the user. |
| + When evaluating whether to show a user a preview, the preview might be |
| + disallowed for various reasons. If the preview is disallowed, then this |
| + reports the reason for disallowing it. If the preview is allowed, then this |
| + reports "Previews Allowed". |
| </summary> |
| </histogram> |
| -<histogram name="Previews.InfoBarAction.LitePage" enum="PreviewsInfoBarAction"> |
| +<histogram name="Previews.InfoBarAction" enum="PreviewsInfoBarAction"> |
| <owner>bengr@chromium.org</owner> |
| <owner>megjablon@chromium.org</owner> |
| <summary> |
| - User interactions with the previews LitePage "Saved data" infobar. |
|
Steven Holte
2017/05/03 23:57:44
Mark histograms obsolete rather than deleting them
Steven Holte
2017/05/04 00:00:34
Oh, actually I see these are just now described th
|
| - These include: |
| - |
| - Displays of the infobar and clicks on the "Load original" link. |
| - Whether the infobar was dismissed by navigation or the user clicking on |
| - "X" close button. |
| - </summary> |
| -</histogram> |
| - |
| -<histogram name="Previews.InfoBarAction.LoFi" enum="PreviewsInfoBarAction"> |
| - <owner>bengr@chromium.org</owner> |
| - <owner>megjablon@chromium.org</owner> |
| - <summary> |
| - User interactions with the previews Lo-Fi "Saved data" infobar. |
| - These include: |
| - |
| - Displays of the infobar and clicks on the "Load original" link. |
| - Whether the infobar was dismissed by navigation or the user clicking on |
| - "X" close button. |
| - </summary> |
| -</histogram> |
| - |
| -<histogram name="Previews.InfoBarAction.Offline" enum="PreviewsInfoBarAction"> |
| - <owner>bengr@chromium.org</owner> |
| - <owner>megjablon@chromium.org</owner> |
| - <summary> |
| - User interactions with the previews Offline "Faster page loaded" |
| - infobar. These include: |
| + User interactions with the previews "Saved data" infobar. These |
| + include: |
| Displays of the infobar and clicks on the "Load original" link. |
| Whether the infobar was dismissed by navigation or the user clicking on |
| @@ -55441,12 +55417,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| -<histogram name="Previews.OptOut.UserOptedOut.Offline" |
| - enum="PreviewsUserOptedOut"> |
| +<histogram name="Previews.OptOut.UserOptedOut" enum="PreviewsUserOptedOut"> |
| <owner>ryansturm@chromium.org</owner> |
| <summary> |
| - Whether the user chose to reload the full page when shown an offline |
| - preview. |
| + Whether the user chose to reload the original page when shown a preview. |
| </summary> |
| </histogram> |
| @@ -126049,7 +126023,11 @@ from previous Chrome versions. |
| <histogram_suffixes name="Previews.Types" separator="."> |
| <suffix name="Offline" label="Offline previews"/> |
| <suffix name="ClientLoFi" label="Client LoFi previews"/> |
| + <suffix name="LitePage" label="Lite page previews"/> |
| + <suffix name="LoFi" label="Server LoFi previews"/> |
| <affected-histogram name="Previews.EligibilityReason"/> |
| + <affected-histogram name="Previews.InfoBarAction"/> |
| + <affected-histogram name="Previews.OptOut.UserOptedOut"/> |
| </histogram_suffixes> |
| <histogram_suffixes name="ProcessType" separator="."> |