Move NGConstraintSpace utility methods to a separate file

Move NGConstraintSpace utility methods to a separate file

These methods will be used by text/block layout algorithms.

BUG=635619
Review-Url: https://codereview.chromium.org/2760043004
Cr-Commit-Position: refs/heads/master@{#458434}
Committed: https://chromium.googlesource.com/chromium/src/+/97fe29afc98d07e5e246dca8e92f8dc63c3619c7

[Gleb Lanbin, 2017-03-20 23:39:57]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2017-03-20 23:40:32]

glebl@chromium.org changed reviewers:
+ cbiesinger@chromium.org, ikilpatrick@chromium.org

[Gleb Lanbin, 2017-03-20 23:40:37]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:41:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-03-21 01:37:55]

https://codereview.chromium.org/2760043004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_space_utils.h (right):

https://codereview.chromium.org/2760043004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_space_utils.h:21: CORE_EXPORT bool
IsNewFormattingContextForInFlowBlockLevelChild(
missing? :P

[Gleb Lanbin, 2017-03-21 02:01:10]

https://codereview.chromium.org/2760043004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_space_utils.h (right):

https://codereview.chromium.org/2760043004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_space_utils.h:21: CORE_EXPORT bool
IsNewFormattingContextForInFlowBlockLevelChild(
On 2017/03/21 01:37:55, ikilpatrick wrote:
> missing? :P

what is missing?

[ikilpatrick, 2017-03-21 02:05:51]

lgtm, sorry i'm a doofus.

[Gleb Lanbin, 2017-03-21 02:06:58]

On 2017/03/21 02:05:51, ikilpatrick wrote:
> lgtm, sorry i'm a doofus.

np, thanks.

Christian, I still need your review/approve for BUILD.gn.

[commit-bot: I haz the power, 2017-03-21 02:38:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 02:38:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-03-21 03:34:24]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 03:34:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 04:59:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 04:59:18]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2017-03-21 16:32:12]

lgtm, sorry for the delay

[Gleb Lanbin, 2017-03-21 16:32:30]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:33:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 16:37:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490113950469880,
"parent_rev": "cb14b0154274f49655ae79daabe0bd73ac9be883", "commit_rev":
"97fe29afc98d07e5e246dca8e92f8dc63c3619c7"}

[commit-bot: I haz the power, 2017-03-21 16:38:32]

Description was changed from

==========
Move NGConstraintSpace utility methods to a separate file

These methods will be used by text/block layout algorithms.

BUG=635619
==========

to

==========
Move NGConstraintSpace utility methods to a separate file

These methods will be used by text/block layout algorithms.

BUG=635619

Review-Url: https://codereview.chromium.org/2760043004
Cr-Commit-Position: refs/heads/master@{#458434}
Committed:
https://chromium.googlesource.com/chromium/src/+/97fe29afc98d07e5e246dca8e92f...
==========

[commit-bot: I haz the power, 2017-03-21 16:38:34]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97fe29afc98d07e5e246dca8e92f...