Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2760043003: Roll back chromite for Simple Chrome (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll back chromite for Simple Chrome The following chromite change breaks Simple Chrome: https://chromium-review.googlesource.com/455237 This rolls back the following changes from chromite while we debug it: commit 0d03f0f74706932433e8e9b789d46d920713633c Author: Jacob Dufault <jdufault@google.com>; Reviewed-on: https://chromium-review.googlesource.com/453921 commit 392c11ebc92e1639b0ce9616eceac02cbe2d368a Author: Don Garrett <dgarrett@google.com>; Reviewed-on: https://chromium-review.googlesource.com/452077 commit 3398d1f358e6c3810d3026032986075d7fd97d80 Author: Ilja H. Friedel <ihf@chromium.org>; Reviewed-on: https://chromium-review.googlesource.com/455237 NOTE: This should only affect Simple Chrome. BUG=703259 TBR=jdufault@chromium.org Review-Url: https://codereview.chromium.org/2760043003 Cr-Commit-Position: refs/heads/master@{#458178} Committed: https://chromium.googlesource.com/chromium/src/+/76dfcb8d0a6fececf9a5bdb9e6e1450e050073e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
3 years, 9 months ago (2017-03-20 19:28:39 UTC) #2
dgarrett-goog
lgtm
3 years, 9 months ago (2017-03-20 19:36:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760043003/1
3 years, 9 months ago (2017-03-20 19:45:32 UTC) #7
jdufault
lgtm, thanks
3 years, 9 months ago (2017-03-20 20:22:13 UTC) #8
ilja
Steven's change will fix the deploy issue. https://chromium-review.googlesource.com/#/c/457422/ Notice that deploy_chrome was never quite clean, ...
3 years, 9 months ago (2017-03-20 20:24:35 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 20:55:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76dfcb8d0a6fececf9a5bdb9e6e1...

Powered by Google App Engine
This is Rietveld 408576698