Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2760033003:
Modernize web development style guide (Closed)
DescriptionModernize web development style guide
Converts
http://www.chromium.org/developers/web-development-style-guide
to markdown and brushes up a few things.
R=dpapad@chromium.org
BUG=
NOTRY=true
Review-Url: https://codereview.chromium.org/2760033003
Cr-Commit-Position: refs/heads/master@{#458629}
Committed: https://chromium.googlesource.com/chromium/src/+/04f8d562c6f8d033b0fb472a2f014f799dfb7d34
Patch Set 1 #Patch Set 2 : add owners #
Total comments: 8
Patch Set 3 : set paste! #Patch Set 4 : add michaelpg@ as owner #Messages
Total messages: 24 (11 generated)
Description was changed from ========== Modernize web development style guide R=dpapad@chromium.org BUG= ========== to ========== Modernize web development style guide Converts http://www.chromium.org/developers/web-development-style-guide to markdown and brushes up a few things. R=dpapad@chromium.org BUG= ==========
LGTM
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
dbeam@chromium.org changed reviewers: + ben@chromium.org
+ben@ for OWNERS
yay! https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md File styleguide/web/web.md (right): https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md#n... styleguide/web/web.md:142: * Exception: `camelCase` is allowed in Polymer code for easier indent off https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md#n... styleguide/web/web.md:175: * If you're labelling purely for accessibility, e.g. a `<select>`, use indent off? https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md#n... styleguide/web/web.md:377: * `behaviors` etc https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md#n... styleguide/web/web.md:389: This makes changing the type of `this.foo` easier (as the `@type` is spacing intentional?
https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md File styleguide/web/web.md (right): https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md#n... styleguide/web/web.md:142: * Exception: `camelCase` is allowed in Polymer code for easier On 2017/03/21 18:02:15, michaelpg wrote: > indent off Done. https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md#n... styleguide/web/web.md:175: * If you're labelling purely for accessibility, e.g. a `<select>`, use On 2017/03/21 18:02:16, michaelpg wrote: > indent off? Done. https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md#n... styleguide/web/web.md:377: * `behaviors` On 2017/03/21 18:02:16, michaelpg wrote: > etc Done. https://codereview.chromium.org/2760033003/diff/20001/styleguide/web/web.md#n... styleguide/web/web.md:389: This makes changing the type of `this.foo` easier (as the `@type` is On 2017/03/21 18:02:16, michaelpg wrote: > spacing intentional? no, all of this is because paste mode
lgtm
michaelpg@: I added you as an owner of this for all your great work on the style guide (especially Polymer stuff) as we discussed, thanks for your help. thanks to everybody for the reviews.
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org, ben@chromium.org Link to the patchset: https://codereview.chromium.org/2760033003/#ps60001 (title: "add michaelpg@ as owner")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
Description was changed from ========== Modernize web development style guide Converts http://www.chromium.org/developers/web-development-style-guide to markdown and brushes up a few things. R=dpapad@chromium.org BUG= ========== to ========== Modernize web development style guide Converts http://www.chromium.org/developers/web-development-style-guide to markdown and brushes up a few things. R=dpapad@chromium.org BUG= NOTRY=true ==========
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490157295183330,
"parent_rev": "b74f91256e77c40adf4e5a787b0cdcec67d1cfbd", "commit_rev":
"04f8d562c6f8d033b0fb472a2f014f799dfb7d34"}
Message was sent while issue was closed.
Description was changed from ========== Modernize web development style guide Converts http://www.chromium.org/developers/web-development-style-guide to markdown and brushes up a few things. R=dpapad@chromium.org BUG= NOTRY=true ========== to ========== Modernize web development style guide Converts http://www.chromium.org/developers/web-development-style-guide to markdown and brushes up a few things. R=dpapad@chromium.org BUG= NOTRY=true Review-Url: https://codereview.chromium.org/2760033003 Cr-Commit-Position: refs/heads/master@{#458629} Committed: https://chromium.googlesource.com/chromium/src/+/04f8d562c6f8d033b0fb472a2f01... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/04f8d562c6f8d033b0fb472a2f01... |
