Fix tab restore for view-source Chrome extension pages (Merge to M58).

Fix tab restore for view-source Chrome extension pages (Merge to M58).

Previously, for non-web-accessible pages, this was blocked by the
check in ShouldAllowOpenURL, and generated a DumpWithoutCrashing
report because the source SiteInstance ("about:") was not
HTTP/HTTPS/extension and the target URL was not a WAR.  The source
SiteInstance was wrong because content::HandleViewSource disallowed
view-source navigations to the chrome-extension scheme and overwrote
the destination URL to about:blank.  See full analysis in issue
699428.

The fix adds chrome-extension to the list of schemes allowed for
view-source.  It also fixes an issue where the restored view-source
tab's visible URL ended up at chrome://bookmarks, rather than
view-source:chrome-extension://<bookmark_extension_id>/.

BUG=699428, 698709, 696034, 700610
Review-Url: https://codereview.chromium.org/2740013008
Cr-Commit-Position: refs/heads/master@{#457582}
(cherry picked from commit 94875b3b4d4a1fc047b99214f30078f3780259f0)

Review-Url: https://codereview.chromium.org/2760023002 .
Cr-Commit-Position: refs/branch-heads/3029@{#301}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/7495c6fd9e5f9823396b508f4145450589853391

[alexmos, 2017-03-20 17:11:36]

Description was changed from

==========
Fix tab restore for view-source Chrome extension pages (Merge to M58).

Previously, for non-web-accessible pages, this was blocked by the
check in ShouldAllowOpenURL, and generated a DumpWithoutCrashing
report because the source SiteInstance ("about:") was not
HTTP/HTTPS/extension and the target URL was not a WAR.  The source
SiteInstance was wrong because content::HandleViewSource disallowed
view-source navigations to the chrome-extension scheme and overwrote
the destination URL to about:blank.  See full analysis in issue
699428.

The fix adds chrome-extension to the list of schemes allowed for
view-source.  It also fixes an issue where the restored view-source
tab's visible URL ended up at chrome://bookmarks, rather than
view-source:chrome-extension://<bookmark_extension_id>/.

BUG=699428,698709,696034,700610

Review-Url: https://codereview.chromium.org/2740013008
Cr-Commit-Position: refs/heads/master@{#457582}
(cherry picked from commit 94875b3b4d4a1fc047b99214f30078f3780259f0)
==========

to

==========
Fix tab restore for view-source Chrome extension pages (Merge to M58).

Previously, for non-web-accessible pages, this was blocked by the
check in ShouldAllowOpenURL, and generated a DumpWithoutCrashing
report because the source SiteInstance ("about:") was not
HTTP/HTTPS/extension and the target URL was not a WAR.  The source
SiteInstance was wrong because content::HandleViewSource disallowed
view-source navigations to the chrome-extension scheme and overwrote
the destination URL to about:blank.  See full analysis in issue
699428.

The fix adds chrome-extension to the list of schemes allowed for
view-source.  It also fixes an issue where the restored view-source
tab's visible URL ended up at chrome://bookmarks, rather than
view-source:chrome-extension://<bookmark_extension_id>/.

BUG=699428,698709,696034,700610

Review-Url: https://codereview.chromium.org/2740013008
Cr-Commit-Position: refs/heads/master@{#457582}
(cherry picked from commit 94875b3b4d4a1fc047b99214f30078f3780259f0)

Review-Url: https://codereview.chromium.org/2760023002 .
Cr-Commit-Position: refs/branch-heads/3029@{#301}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/7495c6fd9e5f9823396b508f4145...
==========

[alexmos, 2017-03-20 17:11:38]

Committed patchset #1 (id:1) manually as
7495c6fd9e5f9823396b508f4145450589853391.