Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2760003002: [Home] Use white doodle background when Chrome Home is enabled (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by Theresa
Modified:
1 month ago
CC:
chromium-reviews, noyau, Bernhard Bauer
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Use white doodle background when Chrome Home is enabled Use a white background, rather than gray, for the Google doodle when Chrome Home is enabled. Also renames the "transparent" param to "gray_background" in several methods to more accurately describe what is being requested. BUG=701145 Review-Url: https://codereview.chromium.org/2760003002 Cr-Commit-Position: refs/heads/master@{#458244} Committed: https://chromium.googlesource.com/chromium/src/+/f12415a5fe8a9371755676430a848678f458e07b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update ios/chrome/browser/google/google_logo_service.mm #

Total comments: 2

Patch Set 3 : [Home] Use white doodle background when Chrome Home is enabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M chrome/browser/android/logo_service.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M components/search_provider_logos/google_logo_api.h View 1 chunk +1 line, -1 line 0 comments Download
M components/search_provider_logos/google_logo_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/search_provider_logos/logo_tracker.h View 1 4 chunks +7 lines, -5 lines 0 comments Download
M components/search_provider_logos/logo_tracker.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/search_provider_logos/logo_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/google/google_logo_service.mm View 1 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 21 (11 generated)
Theresa
bauerb@ - ptal at logo_service.cc justincohen@ - ptal at parameter renaming in components/search_provider_logos/*
1 month ago (2017-03-20 16:56:27 UTC) #4
justincohen
https://codereview.chromium.org/2760003002/diff/1/chrome/browser/android/logo_service.cc File chrome/browser/android/logo_service.cc (right): https://codereview.chromium.org/2760003002/diff/1/chrome/browser/android/logo_service.cc#newcode133 chrome/browser/android/logo_service.cc:133: gray_background); Please update ios/chrome/browser/google/google_logo_service.mm to replace /* transparent */. ...
1 month ago (2017-03-20 17:16:30 UTC) #5
Theresa
https://codereview.chromium.org/2760003002/diff/1/chrome/browser/android/logo_service.cc File chrome/browser/android/logo_service.cc (right): https://codereview.chromium.org/2760003002/diff/1/chrome/browser/android/logo_service.cc#newcode133 chrome/browser/android/logo_service.cc:133: gray_background); On 2017/03/20 17:16:30, justincohen wrote: > Please update ...
1 month ago (2017-03-20 17:29:52 UTC) #6
justincohen
LGTM. noyau@ for recent discussion on grey doodle.
1 month ago (2017-03-20 17:31:22 UTC) #7
Theresa
bauerb@ -> cc (OOO for the next week) +dfalcantara@ for chrome/browser/android/logo_service.cc +rohitrao@ for ios/chrome/browser/google/google_logo_service.mm
1 month ago (2017-03-20 17:34:23 UTC) #9
slow (dfalcantara)
c/b/android lgtm https://codereview.chromium.org/2760003002/diff/20001/chrome/browser/android/logo_service.cc File chrome/browser/android/logo_service.cc (right): https://codereview.chromium.org/2760003002/diff/20001/chrome/browser/android/logo_service.cc#newcode126 chrome/browser/android/logo_service.cc:126: bool gray_background = use_gray_background? sounds like the ...
1 month ago (2017-03-20 18:01:36 UTC) #10
Theresa
https://codereview.chromium.org/2760003002/diff/20001/chrome/browser/android/logo_service.cc File chrome/browser/android/logo_service.cc (right): https://codereview.chromium.org/2760003002/diff/20001/chrome/browser/android/logo_service.cc#newcode126 chrome/browser/android/logo_service.cc:126: bool gray_background = On 2017/03/20 18:01:36, dfalcantara (load balance ...
1 month ago (2017-03-20 21:58:57 UTC) #12
rohitrao
ios/ lgtm
1 month ago (2017-03-20 23:25:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760003002/40001
1 month ago (2017-03-20 23:36:06 UTC) #18
commit-bot: I haz the power
1 month ago (2017-03-20 23:51:38 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f12415a5fe8a9371755676430a84...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46