Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2759963003: S390: Change printf format specifier for size_t in heap.cc and spaces.cc (Closed)

Created:
3 years, 9 months ago by rayb
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, JaideepBajwa
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Change printf format specifier for size_t in heap.cc and spaces.cc On S390, GCC seems to treat size_t as 'long_unsigned_int'. Which conflicts with the %d format specifier since that expects an 'int'. So changing the macro to PRIuS. This seems to fix the issue while retaining the expected behaviour for all other systems. R=mlippautz@chromium.org, hpayer@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2759963003 Cr-Commit-Position: refs/heads/master@{#43988} Committed: https://chromium.googlesource.com/v8/v8/+/e25ac28747d81f92d1f443213db2b87c3fd92f2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rayb
ptal
3 years, 9 months ago (2017-03-20 19:35:02 UTC) #1
Michael Lippautz
On 2017/03/20 19:35:02, rayb wrote: > ptal lgtm
3 years, 9 months ago (2017-03-21 08:10:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759963003/1
3 years, 9 months ago (2017-03-21 14:54:35 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 16:07:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e25ac28747d81f92d1f443213db2b87c3fd...

Powered by Google App Engine
This is Rietveld 408576698