Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2759943003: WebVR: add explicit texture delete, fix formatting (Closed)

Created:
3 years, 9 months ago by klausw
Modified:
3 years, 9 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, Kimmo Kinnunen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR: add explicit texture delete, fix formatting BUG=703049 Review-Url: https://codereview.chromium.org/2759943003 Cr-Commit-Position: refs/heads/master@{#458223} Committed: https://chromium.googlesource.com/chromium/src/+/c3bb5991a5b4cc6b632b1fe1d9368469826f5f30

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move clang format comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
klausw
3 years, 9 months ago (2017-03-20 20:35:17 UTC) #3
mthiesse
lgtm https://codereview.chromium.org/2759943003/diff/1/chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc File chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc (right): https://codereview.chromium.org/2759943003/diff/1/chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc#newcode58 chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc:58: /* clang-format on */ nit: move this a ...
3 years, 9 months ago (2017-03-20 20:39:22 UTC) #4
klausw
https://codereview.chromium.org/2759943003/diff/1/chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc File chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc (right): https://codereview.chromium.org/2759943003/diff/1/chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc#newcode58 chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc:58: /* clang-format on */ On 2017/03/20 20:39:22, mthiesse wrote: ...
3 years, 9 months ago (2017-03-20 21:33:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759943003/20001
3 years, 9 months ago (2017-03-20 21:35:01 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 23:09:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c3bb5991a5b4cc6b632b1fe1d936...

Powered by Google App Engine
This is Rietveld 408576698