components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc - Issue 2759943002: [Remote suggestions] Do not fetch before EULA accepted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc

Issue 2759943002: [Remote suggestions] Do not fetch before EULA accepted (Closed)

Patch Set: Tim's comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc ('k') | ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc

diff --git a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc

index b5ae799498a46492151a937672e36bef31a5edc7..db44301cd66632268279da0ac0c4c970e56c3323 100644

--- a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc

+++ b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc

@@ -146,7 +146,7 @@ class SchedulingRemoteSuggestionsProviderTest

base::MakeUnique<SchedulingRemoteSuggestionsProvider>(

/*observer=*/nullptr, std::move(underlying_provider),

&persistent_scheduler_, &user_classifier_, utils_.pref_service(),

- std::move(test_clock));

+ utils_.pref_service(), std::move(test_clock));

}

tschumann 2017/03/22 09:47:02 (I could have sworn I wrote this comment yesterday

jkrcal 2017/03/22 16:48:01 Done.

void SetVariationParameter(const std::string& param_name,