[Remote suggestions] Do not fetch before EULA accepted

components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h"
 
 #include <memory>
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 128 matching lines @@
     underlying_provider_ = underlying_provider.get();
 
     auto test_clock = base::MakeUnique<base::SimpleTestClock>();
     test_clock_ = test_clock.get();
     test_clock_->SetNow(base::Time::Now());
 
     scheduling_provider_ =
         base::MakeUnique<SchedulingRemoteSuggestionsProvider>(
             /*observer=*/nullptr, std::move(underlying_provider),
             &persistent_scheduler_, &user_classifier_, utils_.pref_service(),
-            std::move(test_clock));
+            utils_.pref_service(), std::move(test_clock));
   }
 

[tschumann, 2017/03/22 09:47:02]

(I could have sworn I wrote this comment yesterday already, but apparently
not...)
Please add a unit-test making sure we're not fetching before the EULA got
accepted.
(https://codesearch.chromium.org/chromium/src/components/web_resource/eula_acc...
has some hints how to do this easily).

[jkrcal, 2017/03/22 16:48:01]

Done.

   void SetVariationParameter(const std::string& param_name,
                              const std::string& param_value) {
     std::map<std::string, std::string> params = default_variation_params_;
     params[param_name] = param_value;
 
     params_manager_.ClearAllVariationParams();
     params_manager_.SetVariationParamsWithFeatureAssociations(
         ntp_snippets::kStudyName, params,
         {ntp_snippets::kArticleSuggestionsFeature.name});
   }
@@ skipping 597 matching lines @@
   for (int x = 0; x < 5; ++x) {
     scheduling_provider_->OnPersistentSchedulerWakeUp();
     signal_fetch_done.Run(Status::Success());
   }
 
   // For the 6th time, it is blocked by the scheduling provider.
   scheduling_provider_->OnPersistentSchedulerWakeUp();
 }
 
 }  // namespace ntp_snippets