[mus]Add FrameGenerator::SetHighContrastMode(bool)

[mus]Add FrameGenerator::SetHighContrastMode(bool)

Added FrameGenerator::high_contrast_mode_enabled_ flag. The flags of all
FrameGenerators are updated by WindowServer when high contrast mode is toggled
by AccessibilityManager for the current active user.

Toggling high contrast mode triggers a BeginFrame for the FrameGenerator.

FrameGeneratorTest.SetHighContrastMode turns on high contrast mode and verifies
that the CompositorFrame received from FrameGenerator has a InvertFilter with
invert amount of 1.0.

BUG=683732
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2759933007
Cr-Commit-Position: refs/heads/master@{#458421}
Committed: https://chromium.googlesource.com/chromium/src/+/0855d091dfde14cb00275864c1534651441f7180

[Alex Z., 2017-03-20 21:32:24]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2017-03-20 21:33:11]

staraz@chromium.org changed reviewers:
+ fsamuel@chromium.org, sadrul@chromium.org

[Alex Z., 2017-03-20 21:33:12]

PTAL

[commit-bot: I haz the power, 2017-03-20 22:02:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-03-20 22:03:47]

lgtm + nit

https://codereview.chromium.org/2759933007/diff/1/services/ui/ws/frame_genera...
File services/ui/ws/frame_generator_unittest.cc (right):

https://codereview.chromium.org/2759933007/diff/1/services/ui/ws/frame_genera...
services/ui/ws/frame_generator_unittest.cc:280: std::vector<cc::FilterOperation>
filter_list = {
Do you need this line? can you simply have this inside expected_filters'
constructor?

[commit-bot: I haz the power, 2017-03-20 22:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:41:24]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Alex Z., 2017-03-20 23:34:16]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2017-03-20 23:34:23]

https://codereview.chromium.org/2759933007/diff/1/services/ui/ws/frame_genera...
File services/ui/ws/frame_generator_unittest.cc (right):

https://codereview.chromium.org/2759933007/diff/1/services/ui/ws/frame_genera...
services/ui/ws/frame_generator_unittest.cc:280: std::vector<cc::FilterOperation>
filter_list = {
On 2017/03/20 22:03:47, Fady Samuel wrote:
> Do you need this line? can you simply have this inside expected_filters'
> constructor?

Done.

[commit-bot: I haz the power, 2017-03-20 23:34:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-03-20 23:41:38]

staraz@chromium.org changed reviewers:
+ msw@chromium.org

[Alex Z., 2017-03-20 23:41:39]

msw@chromium.org: Please review changes in services/ui/ws/

[Alex Z., 2017-03-20 23:41:55]

Description was changed from

==========
[mus]Add FrameGenerator::SetHighContrastMode(bool)

Added FrameGenerator::high_contrast_mode_enabled_ flag. The flags of all
FrameGenerators are updated by WindowServer when high contrast mode is toggled
by AccessibilityManager for the current active user.

Toggling high contrast mode triggers a BeginFrame for the FrameGenerator.

FrameGeneratorTest.SetHighContrastMode turns on high contrast mode and verifies
that the CompositorFrame received from FrameGenerator has a InvertFilter with
invert amount of 1.0.

BUG=683732
==========

to

==========
[mus]Add FrameGenerator::SetHighContrastMode(bool)

Added FrameGenerator::high_contrast_mode_enabled_ flag. The flags of all
FrameGenerators are updated by WindowServer when high contrast mode is toggled
by AccessibilityManager for the current active user.

Toggling high contrast mode triggers a BeginFrame for the FrameGenerator.

FrameGeneratorTest.SetHighContrastMode turns on high contrast mode and verifies
that the CompositorFrame received from FrameGenerator has a InvertFilter with
invert amount of 1.0.

BUG=683732

TBR=msw@chromium.org
==========

[sadrul, 2017-03-20 23:47:11]

nice! lgtm

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator_unittest.cc (right):

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator_unittest.cc:105: const cc::RenderPassList&
last_render_pass_list() {
const method

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator_unittest.cc:180: const cc::RenderPassList&
LastRenderPassList() {
ditto

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/window_s...
File services/ui/ws/window_server.cc (right):

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/window_s...
services/ui/ws/window_server.cc:279: bool
WindowServer::IsActiveUserInHighContrastMode() const {
Can you remove this code too? (and
PlatformDisplayDelegate::IsInHighContrastMode(), and other methods which are no
longer used)

[msw, 2017-03-20 23:55:26]

lgtm with a minor q

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:142:
frame.render_pass_list.back()->filters.Append(
q: why not continue using |render_pass| here?

[commit-bot: I haz the power, 2017-03-21 00:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 00:35:42]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2017-03-21 14:10:12]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 14:10:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-03-21 14:11:32]

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator_unittest.cc (right):

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator_unittest.cc:105: const cc::RenderPassList&
last_render_pass_list() {
On 2017/03/20 23:47:10, sadrul wrote:
> const method

Done.

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator_unittest.cc:180: const cc::RenderPassList&
LastRenderPassList() {
On 2017/03/20 23:47:10, sadrul wrote:
> ditto

Done.

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/window_s...
File services/ui/ws/window_server.cc (right):

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/window_s...
services/ui/ws/window_server.cc:279: bool
WindowServer::IsActiveUserInHighContrastMode() const {
On 2017/03/20 23:47:10, sadrul wrote:
> Can you remove this code too? (and
> PlatformDisplayDelegate::IsInHighContrastMode(), and other methods which are
no
> longer used)

Done.

[commit-bot: I haz the power, 2017-03-21 15:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 15:06:16]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2017-03-21 15:14:34]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-03-21 15:14:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, sadrul@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2759933007/#ps40001
(title: "Addressed nits")

[commit-bot: I haz the power, 2017-03-21 15:14:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 15:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490109274858430,
"parent_rev": "a3d6db6921ab508bc66d04a8141b872325a7b5c2", "commit_rev":
"0855d091dfde14cb00275864c1534651441f7180"}

[commit-bot: I haz the power, 2017-03-21 15:24:24]

Description was changed from

==========
[mus]Add FrameGenerator::SetHighContrastMode(bool)

Added FrameGenerator::high_contrast_mode_enabled_ flag. The flags of all
FrameGenerators are updated by WindowServer when high contrast mode is toggled
by AccessibilityManager for the current active user.

Toggling high contrast mode triggers a BeginFrame for the FrameGenerator.

FrameGeneratorTest.SetHighContrastMode turns on high contrast mode and verifies
that the CompositorFrame received from FrameGenerator has a InvertFilter with
invert amount of 1.0.

BUG=683732

TBR=msw@chromium.org
==========

to

==========
[mus]Add FrameGenerator::SetHighContrastMode(bool)

Added FrameGenerator::high_contrast_mode_enabled_ flag. The flags of all
FrameGenerators are updated by WindowServer when high contrast mode is toggled
by AccessibilityManager for the current active user.

Toggling high contrast mode triggers a BeginFrame for the FrameGenerator.

FrameGeneratorTest.SetHighContrastMode turns on high contrast mode and verifies
that the CompositorFrame received from FrameGenerator has a InvertFilter with
invert amount of 1.0.

BUG=683732

TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2759933007
Cr-Commit-Position: refs/heads/master@{#458421}
Committed:
https://chromium.googlesource.com/chromium/src/+/0855d091dfde14cb00275864c153...
==========

[commit-bot: I haz the power, 2017-03-21 15:24:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0855d091dfde14cb00275864c153...

[Alex Z., 2017-03-21 15:30:53]

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2759933007/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:142:
frame.render_pass_list.back()->filters.Append(
On 2017/03/20 23:55:26, msw wrote:
> q: why not continue using |render_pass| here?

render_pass is moved on line 130.