Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2759933006: Rebaseline several invalidation tests (Closed)

Created:
3 years, 9 months ago by Stephen Chennney
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline several invalidation tests These tests may reveal invalidation issues, but right now they are failing due to changes in font rendering. Rebaseline them and leave the bugs open in the event invalidation really is broken (it doesn't seem that way to me). TBR=wangxianzhu@chromium.org BUG=646010, 646016 Review-Url: https://codereview.chromium.org/2759933006 Cr-Commit-Position: refs/heads/master@{#458469} Committed: https://chromium.googlesource.com/chromium/src/+/3e94eda8b670fa91fff645beaa8cce479055e092

Patch Set 1 #

Patch Set 2 : New baselines #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -123 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 2 chunks +14 lines, -16 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/selected-replaced-expected.txt View 1 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selected-replaced-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selected-replaced-expected.txt View 1 1 chunk +19 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-rtl-double-linebreak-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table-expected.txt View 1 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.txt View 1 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table-expected.txt View 1 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table-expected.txt View 1 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selected-replaced-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selected-replaced-expected.txt View 1 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selected-replaced-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selected-replaced-expected.txt View 1 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table-expected.txt View 1 1 chunk +26 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.txt View 1 2 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759933006/20001
3 years, 9 months ago (2017-03-21 14:25:29 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-21 15:39:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759933006/40001
3 years, 9 months ago (2017-03-21 16:35:17 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 18:03:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e94eda8b670fa91fff645beaa8c...

Powered by Google App Engine
This is Rietveld 408576698