Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2759913002: webkitpy: Small changes to merging script (Closed)

Created:
3 years, 9 months ago by mithro
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Small changes to merging script Small changes to allow the merging script to work in the buildbot environment. BUG=524758 Review-Url: https://codereview.chromium.org/2759913002 Cr-Commit-Position: refs/heads/master@{#458395} Committed: https://chromium.googlesource.com/chromium/src/+/d2908c0a13e525bffd180f9aa541078de4b9df8e

Patch Set 1 #

Patch Set 2 : Enable exparchive for Linux Trusty.. #

Patch Set 3 : Fixing. #

Patch Set 4 : Fixing. #

Patch Set 5 : Fixes. #

Patch Set 6 : Fixes. #

Patch Set 7 : Fixes. #

Patch Set 8 : Fixes. #

Patch Set 9 : Fixes. #

Patch Set 10 : Seems to be working. #

Patch Set 11 : Rebase onto master. #

Total comments: 4

Patch Set 12 : Fixing for rename. #

Patch Set 13 : Fixing for dsansome's review. #

Patch Set 14 : webkitpy: Small changes to merging script #

Patch Set 15 : Fixing more small errors. #

Patch Set 16 : got_revision_cp #

Patch Set 17 : 20 shards #

Patch Set 18 : Reverting change to chromium.linux.json for landing. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -15 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +13 lines, -1 line 1 comment Download
M third_party/WebKit/Tools/Scripts/merge-layout-test-results View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +48 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/merge_results.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/merge_results_unittest.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
dsansome
lgtm https://codereview.chromium.org/2759913002/diff/200001/third_party/WebKit/Tools/Scripts/merge-layout-test-results File third_party/WebKit/Tools/Scripts/merge-layout-test-results (right): https://codereview.chromium.org/2759913002/diff/200001/third_party/WebKit/Tools/Scripts/merge-layout-test-results#newcode104 third_party/WebKit/Tools/Scripts/merge-layout-test-results:104: logging.info(argv) Remove this line before submitting https://codereview.chromium.org/2759913002/diff/200001/third_party/WebKit/Tools/Scripts/merge-layout-test-results#newcode115 third_party/WebKit/Tools/Scripts/merge-layout-test-results:115: ...
3 years, 9 months ago (2017-03-21 09:18:35 UTC) #4
engedy
Sheriff star rubberstamp LGTM!
3 years, 9 months ago (2017-03-21 09:39:37 UTC) #5
mithro
https://codereview.chromium.org/2759913002/diff/200001/third_party/WebKit/Tools/Scripts/merge-layout-test-results File third_party/WebKit/Tools/Scripts/merge-layout-test-results (right): https://codereview.chromium.org/2759913002/diff/200001/third_party/WebKit/Tools/Scripts/merge-layout-test-results#newcode104 third_party/WebKit/Tools/Scripts/merge-layout-test-results:104: logging.info(argv) On 2017/03/21 09:18:34, dsansome wrote: > Remove this ...
3 years, 9 months ago (2017-03-21 09:43:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759913002/340001
3 years, 9 months ago (2017-03-21 12:26:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/344230)
3 years, 9 months ago (2017-03-21 13:11:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759913002/340001
3 years, 9 months ago (2017-03-21 13:18:47 UTC) #13
commit-bot: I haz the power
Committed patchset #18 (id:340001) as https://chromium.googlesource.com/chromium/src/+/d2908c0a13e525bffd180f9aa541078de4b9df8e
3 years, 9 months ago (2017-03-21 14:02:09 UTC) #16
Dirk Pranke
3 years, 8 months ago (2017-04-02 22:56:52 UTC) #18
Message was sent while issue was closed.
https://codereview.chromium.org/2759913002/diff/340001/testing/buildbot/chrom...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2759913002/diff/340001/testing/buildbot/chrom...
testing/buildbot/chromium.fyi.json:12924: ],
Why did you make these all arguments, rather than just hardcoding the logic in
the merge script? The merge script only has one purpose, so it seems like
there's no need for the configurability?

Powered by Google App Engine
This is Rietveld 408576698