Issue 27599002: A page should exit fullscreen mode if it opens a new popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27599002: A page should exit fullscreen mode if it opens a new popup (Closed)

Created:
7 years, 2 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

A page should exit fullscreen mode if it opens a new popup If a fullscreen page opens a popup, the popup would be hidden and therefore invisible to the user. To avoid this, exit fullscreen mode before opening a new window. Imported from http://trac.webkit.org/changeset/157534 R=abarth@chromium.org TEST=fullscreen/full-screen-exit-when-popup.html BUG=304547 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159834

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
A +	LayoutTests/fullscreen/full-screen-exit-when-popup.html	View	2 chunks	+7 lines, -10 lines	0 comments	Download
A +	LayoutTests/fullscreen/full-screen-exit-when-popup-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/ChromeClientImpl.cpp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/web/FrameLoaderClientImpl.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/27599002/1

7 years, 2 months ago (2013-10-17 02:07:22 UTC) #3

jochen (gone - plz use gerrit)

7 years, 2 months ago (2013-10-17 07:40:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r159834 (presubmit successful).