Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: LayoutTests/fullscreen/full-screen-exit-when-popup.html

Issue 27599002: A page should exit fullscreen mode if it opens a new popup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fullscreen/full-screen-exit-when-popup-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fullscreen/full-screen-exit-when-popup.html
diff --git a/LayoutTests/fullscreen/full-screen-cancel.html b/LayoutTests/fullscreen/full-screen-exit-when-popup.html
similarity index 79%
copy from LayoutTests/fullscreen/full-screen-cancel.html
copy to LayoutTests/fullscreen/full-screen-exit-when-popup.html
index d670b14a5ba9ee3144f943339d8409690f98920e..f21e98164ebd8b40ecf2845df608db9dce12cb16 100644
--- a/LayoutTests/fullscreen/full-screen-cancel.html
+++ b/LayoutTests/fullscreen/full-screen-exit-when-popup.html
@@ -7,6 +7,10 @@
logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
endTest();
} else {
+ if (window.testRunner) {
+ testRunner.setCanOpenWindows(true);
+ testRunner.setCloseRemainingWindowsWhenComplete(true);
+ }
var callback;
var fullscreenChanged = function(event)
{
@@ -15,28 +19,21 @@
};
waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
- var span = document.getElementsByTagName('span')[0];
-
var spanEnteredFullScreen = function() {
testExpected("document.webkitIsFullScreen", true);
testExpected("document.webkitCurrentFullScreenElement", span);
callback = cancelledFullScreen;
- document.webkitCancelFullScreen();
+ testExpected("window.open('about:blank')", null, "!=");
};
var cancelledFullScreen = function() {
testExpected("document.webkitIsFullScreen", false);
testExpected("document.webkitCurrentFullScreenElement", undefined);
- callback = failFullScreenTest;
- document.webkitCancelFullScreen();
- setTimeout(endTest, 0);
- };
-
- var failFullScreenTest = function() {
- consoleWrite("Should not have received a webkitfullscreenchange event.");
endTest();
};
+ var span = document.getElementsByTagName('span')[0];
+
callback = spanEnteredFullScreen;
runWithKeyDown(function(){span.webkitRequestFullScreen()});
}
« no previous file with comments | « no previous file | LayoutTests/fullscreen/full-screen-exit-when-popup-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698