Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2759893002: Re-record Multi-tab System Health Story (Closed)

Created:
3 years, 9 months ago by vovoy
Modified:
3 years, 9 months ago
Reviewers:
perezju, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-record Multi-tab System Health Story Some page shows "404 Not Found" in the previous recording due to https://github.com/chromium/web-page-replay/issues/73 recording with python 2.7.13 to fix the issue BUG=689388 Review-Url: https://codereview.chromium.org/2759893002 Cr-Commit-Position: refs/heads/master@{#458067} Committed: https://chromium.googlesource.com/chromium/src/+/576e9b3d5a185c7daa2a9ccde1ae51350fd218d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf/page_sets/data/system_health_desktop.json View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/perf/page_sets/data/system_health_desktop_048.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_049.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
vovoy
ref for the issue: https://codereview.chromium.org/2706483003/#msg73
3 years, 9 months ago (2017-03-20 05:28:30 UTC) #5
perezju
lgtm, thanks!
3 years, 9 months ago (2017-03-20 10:36:47 UTC) #8
nednguyen
On 2017/03/20 10:36:47, perezju wrote: > lgtm, thanks! Thanks! lgtm
3 years, 9 months ago (2017-03-20 11:57:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759893002/1
3 years, 9 months ago (2017-03-20 15:12:40 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 15:24:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/576e9b3d5a185c7daa2a9ccde1ae...

Powered by Google App Engine
This is Rietveld 408576698